Mesh Shaders#256
Open
devshgraphicsprogramming wants to merge 10 commits intoDevsh-Graphics-Programming:masterfrom
Open
Mesh Shaders#256devshgraphicsprogramming wants to merge 10 commits intoDevsh-Graphics-Programming:masterfrom
devshgraphicsprogramming wants to merge 10 commits intoDevsh-Graphics-Programming:masterfrom
Conversation
i think i just need to fix the shaders and thats it
[22.12.2025 19:53:22:605382][ERROR]: Descriptor set (000002B092D5C450) doesn't allow descriptor of such type category at binding 1. [22.12.2025 19:53:22:605551][ERROR]: Invalid descriptor type (descriptorWrites[2]) [4c26069f9][nbl::video::ILogicalDevice::updateDescriptorSets - C:\Projects\Nabla\src\nbl\video\ILogicalDevice.cpp:529] this is my error code at MeshRenderer.cpp Line 322 It coudl potentially be that the buffer just isn't flagged for storage buffer (it probably isnt), or it could be a deeper issue. My concern is that if I start tugging on this thread next thing I know I'l be rewriting all of nabla. I'm just going to scrap the current geometry and write a simple cube and call it a day. I verified that the tasks shaders worked correctly at some point during this process, whoevers reading this is just gonna have to take my word for it.
Mesh shader
| @@ -365,7 +356,7 @@ class CSimpleDebugRenderer final : public core::IReferenceCounted | |||
| // | |||
| inline void clearGeometries(const video::ISemaphore::SWaitInfo& info) | |||
| { | |||
| // back to front to avoid O(n^2) resize | |||
| //why woudl oyu delete element by element instead of just deallocating all then clearing once? | |||
Member
Author
There was a problem hiding this comment.
because the cleanup gets deferred to when the semaphore signals, see our Vulkanised 2026 talk about timeline semas
Member
Author
|
@GDBobby do you think you could unify it with the existing geometry displaying/testing example and keep the frag shader then switch between ? esp when PR 1000 lands, this would neatly integrate into our CI system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AnastaZIuk will review and approve