add pipeline executable info reports to performance critical examples#253
Open
karimsayedre wants to merge 2 commits intomasterfrom
Open
add pipeline executable info reports to performance critical examples#253karimsayedre wants to merge 2 commits intomasterfrom
karimsayedre wants to merge 2 commits intomasterfrom
Conversation
30_ComputeShaderPathTracer/main.cpp
Outdated
Comment on lines
35
to
53
| using device_base_t = SimpleWindowedApplication; | ||
| using asset_base_t = BuiltinResourcesApplication; | ||
| using clock_t = std::chrono::steady_clock; | ||
|
|
||
| enum E_LIGHT_GEOMETRY : uint8_t | ||
| using device_base_t = SimpleWindowedApplication; | ||
| using asset_base_t = BuiltinResourcesApplication; | ||
| using clock_t = std::chrono::steady_clock; | ||
|
|
||
| enum E_LIGHT_GEOMETRY : uint8_t | ||
| { | ||
| ELG_SPHERE, | ||
| ELG_TRIANGLE, | ||
| ELG_RECTANGLE, | ||
| ELG_COUNT | ||
| }; | ||
|
|
||
| constexpr static inline uint32_t2 WindowDimensions = { 1280, 720 }; | ||
| constexpr static inline uint32_t MaxFramesInFlight = 5; | ||
| constexpr static inline clock_t::duration DisplayImageDuration = std::chrono::milliseconds(900); | ||
| constexpr static inline uint32_t DefaultWorkGroupSize = 16u; | ||
| constexpr static inline uint32_t MaxDescriptorCount = 256u; | ||
| constexpr static inline uint32_t MaxDepthLog2 = 4u; // 5 | ||
| constexpr static inline uint32_t MaxSamplesLog2 = 10u; // 18 |
There was a problem hiding this comment.
why did you change all the indents ?
Author
There was a problem hiding this comment.
Sorry, reverted that, I'm used to format whole files, we should really use clangformat, anything against that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
74_QuantizedSequenceTestsbut that requires changes to ITester.h (or maybe the inheritor class?)71_RayTracingPipeline, for some reason (probably driver again, pretty sure it is because NSight gives reports the correct pipeline creation flags), vkGetPipelineExecutablePropertiesKHR reports 0 executable count, which means it won't report anything