[FEATURE] - Add a User Interface to the CLEVO Keyboard Colour Program#14
[FEATURE] - Add a User Interface to the CLEVO Keyboard Colour Program#14
Conversation
|
Much much better! Thank you 👍 Make sure you update the README.md file with a "how to use" the GUI program and add the new animations that you have created to the README.md as well. And mark the source code files that you have created with a at the start of the file. Like this: Once that is done, I am happy to approve and that can be merged into the gui_beta branch. |
DeviceIoControl
changed the title
| @@ -0,0 +1,200 @@ | |||
| /*#include "stdafx.h" | |||
There was a problem hiding this comment.
Don't remove the old animations, create a new animation, some people may still want this.
Create a new Header and CPP file and put the new code in there instead.
There was a problem hiding this comment.
You can decide on what you want to name it.
| @@ -1,5 +1,3 @@ | |||
| // Created by DeviceIoControl | |||
There was a problem hiding this comment.
Why is this removed in a bunch of files?
There was a problem hiding this comment.
Oh I think its a mistouch I didn't work on this file actually
There was a problem hiding this comment.
Hmmm. Is there someone else using your GitHub account?
There was a problem hiding this comment.
Not at all I think I've made It whent I wanted to put //Created by BenRango on top of my files dw, I'll pay more attention the next time
| #include "stdafx.h" | ||
| #include "ColourFactory.h" | ||
|
|
||
| std::map<std::wstring, Colour> ColourFactory::CreateInitialMap() |
There was a problem hiding this comment.
What is happening here? Don't over-engineer this. If you want more static colour definitions, put it into Colours.h
| #define INDEX_COLOUR_RED 0 | ||
| #define INDEX_COLOUR_GREEN 1 | ||
| #define INDEX_COLOUR_BLUE 2 | ||
| #define INDEX_COLOUR_GRAY 3 |
There was a problem hiding this comment.
What is the point of this index? No colour-space or keyboard has a "grey" channel.
There was a problem hiding this comment.
Oh, that's because I wanted to add new colors to the “breathe” animation. I didn't know there was already an advanced animation for that.
I was feeling my way, trying to familiarize myself with this code; it was just an experiment.
Sorry I was supposed to remove it later but I forgot
| const auto gray = factory.Create(128, 128, 128); | ||
|
|
||
| // Creating a continuous, looping colour transition | ||
| this->GenerateColourTransform(red, orange, STEPS, FRAME_DURATION_MS); |
There was a problem hiding this comment.
Create a new animation for this. Don't modify existing animations.
2 participants
Hello,
This update introduces new features and enhancements to the keyboard animation functionality:
🚀 New Features
New Animation Mode: Implemented the
singlebreathecommand. This breathing animation now uses only a single user-selectable color.Color Picker: Added a Color Picker for the
singlebreathemode, allowing users to easily choose their desired color.✨ Enhancements
Simplified Selection: The animation mode selection button now displays only the two available modes:
breatheandcolourtransform.Expanded Color Palette: New colors have been added for the
colourtransformandfreshbreatheanimations, offering greater variety.