AI Assistant: improve utils test coverage#33622
Open
dmirgaev wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test coverage around AI Assistant grid command key utilities and makes a helper internal to its module.
Changes:
- Adds Jest coverage for
normalizeKeybehavior across primitive and composite keys. - Makes
compositeKeyToObjectprivate since it is only used bynormalizeKey. - Shortens documentation for
expandTypeArraysToAnyOf.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/utils.ts |
Updates the JSDoc for schema type-array expansion. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/utils.ts |
Makes the composite-key conversion helper module-private. |
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/__tests__/utils.test.ts |
Adds normalizeKey unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.