Grid Demos: fix csp in treelist-overview and grid-rowselection#33618
Open
flagmanAndrew wants to merge 5 commits into
Open
Grid Demos: fix csp in treelist-overview and grid-rowselection#33618flagmanAndrew wants to merge 5 commits into
flagmanAndrew wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make selected demos compatible with the CSP demo server by replacing inline background styles in TreeList Overview employee cells and removing CSP allowlist entries.
Changes:
- Replaces inline
background-imageemployee thumbnails with<img>elements in TreeList Overview for React, ReactJs, Vue, and jQuery. - Updates thumbnail CSS to use
object-fit: contain. - Removes
unsafe-inlinestyle CSP exceptions forTreeList/OverviewandDataGrid/RowSelection.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
apps/demos/utils/server/csp-server.js |
Removes style CSP allowlist entries for the affected demos. |
apps/demos/Demos/TreeList/Overview/Vue/EmployeeCell.vue |
Converts employee image rendering from styled div to img. |
apps/demos/Demos/TreeList/Overview/ReactJs/styles.css |
Updates image sizing behavior for actual img elements. |
apps/demos/Demos/TreeList/Overview/ReactJs/EmployeeCell.js |
Converts employee image rendering from styled div to img. |
apps/demos/Demos/TreeList/Overview/React/styles.css |
Updates image sizing behavior for actual img elements. |
apps/demos/Demos/TreeList/Overview/React/EmployeeCell.tsx |
Converts employee image rendering from styled div to img. |
apps/demos/Demos/TreeList/Overview/jQuery/styles.css |
Updates image sizing behavior for actual img elements. |
apps/demos/Demos/TreeList/Overview/jQuery/index.js |
Converts employee image rendering from styled div to img. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
treelist-overview: remove inline background
grid-rowselection: remove inline 'visibility' attr in jquery