Skip to content

Lookup: Add localization for search input aria-label (T1328842)#33614

Open
r-farkhutdinov wants to merge 1 commit into
DevExpress:26_1from
r-farkhutdinov:26_1_T1328842
Open

Lookup: Add localization for search input aria-label (T1328842)#33614
r-farkhutdinov wants to merge 1 commit into
DevExpress:26_1from
r-farkhutdinov:26_1_T1328842

Conversation

@r-farkhutdinov
Copy link
Copy Markdown
Contributor

No description provided.

@r-farkhutdinov r-farkhutdinov self-assigned this May 18, 2026
Copilot AI review requested due to automatic review settings May 18, 2026 12:20
@r-farkhutdinov r-farkhutdinov requested review from a team as code owners May 18, 2026 12:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a localizable message key dxLookup-ariaLabel for the search input's aria-label inside the Lookup widget, replacing the previously hardcoded 'Search' string. Default English value is added for all locale files (non-English translations are left as "Search" to be filled in by the localization team) and a QUnit test verifies the input uses the localized value.

Changes:

  • Replace hardcoded aria-label: 'Search' in m_lookup.ts with messageLocalization.format('dxLookup-ariaLabel').
  • Add the new dxLookup-ariaLabel key (value "Search") to all locale message JSON files.
  • Add a QUnit test that asserts the search input's aria-label matches the localized dxLookup-ariaLabel value.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

File Description
packages/devextreme/js/__internal/ui/m_lookup.ts Uses messageLocalization.format for the search input's aria-label.
packages/devextreme/js/localization/messages/*.json (30 files) Adds dxLookup-ariaLabel key with default English value "Search".
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/lookup.tests.js New QUnit test validating the localized aria-label is applied to the search input.

Copilot AI review requested due to automatic review settings May 18, 2026 13:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@r-farkhutdinov r-farkhutdinov removed the request for review from a team May 18, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants