Skip to content

Conversation

@r-farkhutdinov
Copy link
Contributor

No description provided.

@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review February 5, 2026 10:43
@r-farkhutdinov r-farkhutdinov requested review from a team as code owners February 5, 2026 10:43
Copilot AI review requested due to automatic review settings February 5, 2026 10:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Speech-to-Text (STT) integration types to the Chat component, along with an inputFieldText property. The changes include TypeScript type declarations and updates to the Angular, React, and Vue framework wrappers.

Changes:

  • Added speechToTextOptions and inputFieldText properties to Chat TypeScript declarations
  • Updated Vue wrapper with STT integration types and nested components
  • Updated React wrapper with STT integration types and nested components
  • Updated Angular wrapper with STT integration types and nested components
  • Modified Angular metadata generation to exclude speechToTextOptions from generation
  • Added Angular suggestion components (appears unrelated to STT)

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/devextreme/ts/dx.all.d.ts Adds inputFieldText and speechToTextOptions properties to dxChatOptions interface
packages/devextreme/js/ui/chat.d.ts Adds SpeechToTextOptions import and new property definitions with JSDoc comments
packages/devextreme-vue/src/chat.ts Adds STT-related imports, types, and nested components (DxSpeechToTextOptions, DxSpeechRecognitionConfig, DxCustomSpeechRecognizer)
packages/devextreme-react/src/chat.ts Adds STT-related imports, types, and nested components with React-specific implementations
packages/devextreme-metadata/make-angular-metadata.ts Excludes speechToTextOptions from Angular metadata generation
packages/devextreme-angular/src/ui/nested/suggestion-dxi.ts Adds generic suggestion component (unrelated to STT, appears incomplete)
packages/devextreme-angular/src/ui/nested/index.ts Exports the new suggestion component
packages/devextreme-angular/src/ui/nested/base/suggestion-dxi.ts Adds base class for suggestion component
packages/devextreme-angular/src/ui/nested/base/index.ts Exports base suggestion class
packages/devextreme-angular/src/ui/chat/nested/suggestion-dxi.ts Adds chat-specific suggestion component (unrelated to STT, appears incomplete)
packages/devextreme-angular/src/ui/chat/nested/speech-to-text-options.ts Adds Angular nested component for STT options
packages/devextreme-angular/src/ui/chat/nested/speech-recognition-config.ts Adds Angular nested component for speech recognition configuration
packages/devextreme-angular/src/ui/chat/nested/index.ts Exports new STT and suggestion components
packages/devextreme-angular/src/ui/chat/nested/custom-speech-recognizer.ts Adds Angular nested component for custom speech recognizer
packages/devextreme-angular/src/ui/chat/index.ts Adds speechToTextOptions property and imports for STT-related modules
Comments suppressed due to low confidence (1)

packages/devextreme-vue/src/chat.ts:119

  • The inputFieldText property is missing from the Vue wrapper. While it's added to the TypeScript declarations (chat.d.ts line 442 and dx.all.d.ts line 11420), it's not included in the Vue component's AccessibleOptions type or in the component configuration. This property should be added to maintain consistency across all wrappers.
type AccessibleOptions = Pick<Properties,
  "accessKey" |
  "activeStateEnabled" |
  "alerts" |
  "dataSource" |
  "dayHeaderFormat" |
  "disabled" |
  "editing" |
  "elementAttr" |
  "emptyViewTemplate" |
  "fileUploaderOptions" |
  "focusStateEnabled" |
  "height" |
  "hint" |
  "hoverStateEnabled" |
  "items" |
  "messageTemplate" |
  "messageTimestampFormat" |
  "onAttachmentDownloadClick" |
  "onDisposing" |
  "onInitialized" |
  "onMessageDeleted" |
  "onMessageDeleting" |
  "onMessageEditCanceled" |
  "onMessageEditingStart" |
  "onMessageEntered" |
  "onMessageUpdated" |
  "onMessageUpdating" |
  "onOptionChanged" |
  "onTypingEnd" |
  "onTypingStart" |
  "reloadOnChange" |
  "rtlEnabled" |
  "showAvatar" |
  "showDayHeaders" |
  "showMessageTimestamp" |
  "showUserName" |
  "speechToTextOptions" |
  "typingUsers" |
  "user" |
  "visible" |
  "width"
>;

@r-farkhutdinov r-farkhutdinov marked this pull request as draft February 5, 2026 10:59
@r-farkhutdinov r-farkhutdinov marked this pull request as ready for review February 6, 2026 13:36
Copilot AI review requested due to automatic review settings February 6, 2026 13:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Copilot AI review requested due to automatic review settings February 6, 2026 14:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings February 6, 2026 20:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated no new comments.

Copy link
Contributor

@mpreyskurantov mpreyskurantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge #32246 first

@r-farkhutdinov r-farkhutdinov force-pushed the 26_1_chat_stt_types branch 2 times, most recently from 933b12f to 7946646 Compare February 10, 2026 09:58
Copilot AI review requested due to automatic review settings February 10, 2026 09:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.

Comment on lines 53 to +55
removeMembers(/\/chat:dxChatOptions\.(fileUploaderOptions|onAttachmentDownloadClick)/),
removeMembers(/\/chat:dxChatOptions.speechToTextOptions/),
removeMembers(/\/chat:dxChatOptions.inputFieldText/),
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make-angular-metadata.ts removes dxChatOptions.speechToTextOptions and dxChatOptions.inputFieldText from Angular metadata, but this PR also adds these options to the Angular/Vue/React wrappers and core typings. If the goal is to expose these options for Chat in Angular, these removeMembers(...) rules will prevent the generated Angular metadata from containing them (and may cause them to disappear on regeneration). Either drop these removals or remove the corresponding wrapper/type additions if they are intentionally unsupported in Angular.

Copilot uses AI. Check for mistakes.
Comment on lines +298 to +305

@Input()
get inputFieldText(): any {
return this._getOption('inputFieldText');
}
set inputFieldText(value: any) {
this._setOption('inputFieldText', value);
}
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new @Input() inputFieldText block is missing the standard JSDoc/[descr:...] comment that the surrounding inputs in this file have. This breaks consistency and can affect generated docs/intellisense for Angular consumers; add the [descr:dxChatOptions.inputFieldText] comment block like other inputs.

Copilot uses AI. Check for mistakes.
Comment on lines 424 to +432


@Input()
get speechToTextOptions(): dxSpeechToTextOptions {
return this._getOption('speechToTextOptions');
}
set speechToTextOptions(value: dxSpeechToTextOptions) {
this._setOption('speechToTextOptions', value);
}
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new @Input() speechToTextOptions block is missing the standard JSDoc/[descr:...] comment that other Chat inputs in this file include. Add the [descr:dxChatOptions.speechToTextOptions] comment block to keep Angular API docs/intellisense consistent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants