-
Notifications
You must be signed in to change notification settings - Fork 667
Chat: Add STT integration types #32399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 26_1
Are you sure you want to change the base?
Chat: Add STT integration types #32399
Conversation
d4cfd5d to
23ddc4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Speech-to-Text (STT) integration types to the Chat component, along with an inputFieldText property. The changes include TypeScript type declarations and updates to the Angular, React, and Vue framework wrappers.
Changes:
- Added
speechToTextOptionsandinputFieldTextproperties to Chat TypeScript declarations - Updated Vue wrapper with STT integration types and nested components
- Updated React wrapper with STT integration types and nested components
- Updated Angular wrapper with STT integration types and nested components
- Modified Angular metadata generation to exclude
speechToTextOptionsfrom generation - Added Angular suggestion components (appears unrelated to STT)
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Adds inputFieldText and speechToTextOptions properties to dxChatOptions interface |
| packages/devextreme/js/ui/chat.d.ts | Adds SpeechToTextOptions import and new property definitions with JSDoc comments |
| packages/devextreme-vue/src/chat.ts | Adds STT-related imports, types, and nested components (DxSpeechToTextOptions, DxSpeechRecognitionConfig, DxCustomSpeechRecognizer) |
| packages/devextreme-react/src/chat.ts | Adds STT-related imports, types, and nested components with React-specific implementations |
| packages/devextreme-metadata/make-angular-metadata.ts | Excludes speechToTextOptions from Angular metadata generation |
| packages/devextreme-angular/src/ui/nested/suggestion-dxi.ts | Adds generic suggestion component (unrelated to STT, appears incomplete) |
| packages/devextreme-angular/src/ui/nested/index.ts | Exports the new suggestion component |
| packages/devextreme-angular/src/ui/nested/base/suggestion-dxi.ts | Adds base class for suggestion component |
| packages/devextreme-angular/src/ui/nested/base/index.ts | Exports base suggestion class |
| packages/devextreme-angular/src/ui/chat/nested/suggestion-dxi.ts | Adds chat-specific suggestion component (unrelated to STT, appears incomplete) |
| packages/devextreme-angular/src/ui/chat/nested/speech-to-text-options.ts | Adds Angular nested component for STT options |
| packages/devextreme-angular/src/ui/chat/nested/speech-recognition-config.ts | Adds Angular nested component for speech recognition configuration |
| packages/devextreme-angular/src/ui/chat/nested/index.ts | Exports new STT and suggestion components |
| packages/devextreme-angular/src/ui/chat/nested/custom-speech-recognizer.ts | Adds Angular nested component for custom speech recognizer |
| packages/devextreme-angular/src/ui/chat/index.ts | Adds speechToTextOptions property and imports for STT-related modules |
Comments suppressed due to low confidence (1)
packages/devextreme-vue/src/chat.ts:119
- The inputFieldText property is missing from the Vue wrapper. While it's added to the TypeScript declarations (chat.d.ts line 442 and dx.all.d.ts line 11420), it's not included in the Vue component's AccessibleOptions type or in the component configuration. This property should be added to maintain consistency across all wrappers.
type AccessibleOptions = Pick<Properties,
"accessKey" |
"activeStateEnabled" |
"alerts" |
"dataSource" |
"dayHeaderFormat" |
"disabled" |
"editing" |
"elementAttr" |
"emptyViewTemplate" |
"fileUploaderOptions" |
"focusStateEnabled" |
"height" |
"hint" |
"hoverStateEnabled" |
"items" |
"messageTemplate" |
"messageTimestampFormat" |
"onAttachmentDownloadClick" |
"onDisposing" |
"onInitialized" |
"onMessageDeleted" |
"onMessageDeleting" |
"onMessageEditCanceled" |
"onMessageEditingStart" |
"onMessageEntered" |
"onMessageUpdated" |
"onMessageUpdating" |
"onOptionChanged" |
"onTypingEnd" |
"onTypingStart" |
"reloadOnChange" |
"rtlEnabled" |
"showAvatar" |
"showDayHeaders" |
"showMessageTimestamp" |
"showUserName" |
"speechToTextOptions" |
"typingUsers" |
"user" |
"visible" |
"width"
>;
packages/devextreme-angular/src/ui/chat/nested/suggestion-dxi.ts
Outdated
Show resolved
Hide resolved
packages/devextreme-angular/src/ui/nested/base/suggestion-dxi.ts
Outdated
Show resolved
Hide resolved
23ddc4a to
981170f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
3d1c909 to
a4037e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.
c887fc9 to
720e61a
Compare
packages/devextreme-angular/src/ui/chat/nested/speech-to-text-options.ts
Show resolved
Hide resolved
e3a79b2 to
720e61a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated no new comments.
mpreyskurantov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge #32246 first
933b12f to
7946646
Compare
7946646 to
ebbfe52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 12 changed files in this pull request and generated 3 comments.
| removeMembers(/\/chat:dxChatOptions\.(fileUploaderOptions|onAttachmentDownloadClick)/), | ||
| removeMembers(/\/chat:dxChatOptions.speechToTextOptions/), | ||
| removeMembers(/\/chat:dxChatOptions.inputFieldText/), |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make-angular-metadata.ts removes dxChatOptions.speechToTextOptions and dxChatOptions.inputFieldText from Angular metadata, but this PR also adds these options to the Angular/Vue/React wrappers and core typings. If the goal is to expose these options for Chat in Angular, these removeMembers(...) rules will prevent the generated Angular metadata from containing them (and may cause them to disappear on regeneration). Either drop these removals or remove the corresponding wrapper/type additions if they are intentionally unsupported in Angular.
|
|
||
| @Input() | ||
| get inputFieldText(): any { | ||
| return this._getOption('inputFieldText'); | ||
| } | ||
| set inputFieldText(value: any) { | ||
| this._setOption('inputFieldText', value); | ||
| } |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new @Input() inputFieldText block is missing the standard JSDoc/[descr:...] comment that the surrounding inputs in this file have. This breaks consistency and can affect generated docs/intellisense for Angular consumers; add the [descr:dxChatOptions.inputFieldText] comment block like other inputs.
|
|
||
|
|
||
| @Input() | ||
| get speechToTextOptions(): dxSpeechToTextOptions { | ||
| return this._getOption('speechToTextOptions'); | ||
| } | ||
| set speechToTextOptions(value: dxSpeechToTextOptions) { | ||
| this._setOption('speechToTextOptions', value); | ||
| } |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new @Input() speechToTextOptions block is missing the standard JSDoc/[descr:...] comment that other Chat inputs in this file include. Add the [descr:dxChatOptions.speechToTextOptions] comment block to keep Angular API docs/intellisense consistent.
No description provided.