Rewrite Readme. Review and improve code examples. #3
Closed
NickVolynkin wants to merge 6 commits intoDevExpress-Examples:25.2.3+from
Closed
Rewrite Readme. Review and improve code examples. #3NickVolynkin wants to merge 6 commits intoDevExpress-Examples:25.2.3+from
NickVolynkin wants to merge 6 commits intoDevExpress-Examples:25.2.3+from
Conversation
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
3 times, most recently
from
6f0837d to
5c9b344
Compare
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
2 times, most recently
from
23b7b40 to
c63aeec
Compare
NickVolynkin
changed the title
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
8 times, most recently
from
7d8af38 to
f720665
Compare
Abadzhev
reviewed
Jan 26, 2026
Contributor
There was a problem hiding this comment.
"Localize Report Dialogs in" - In this case I would use the same preposition as for the word "translate". So you translate or localize "to" a language/locale. But I think we can also have a simpler version. Here's my version:
"Report Dialog Language (Locale):"
Contributor
Author
There was a problem hiding this comment.
Here I wanted to highlight the action of localizing, which is why I used a verb. However, unlike regular buttons, radio buttons show a continuing state. Reports stay localized in German as long as the corresponding radio button is checked. So, it makes sense to use nouns, as in your suggestion.
Comment about the preposition is valid, thanks.
NickVolynkin
commented
Jan 27, 2026
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
2 times, most recently
from
84174e2 to
2c2bb4e
Compare
NickVolynkin
changed the title
NickVolynkin
changed the title
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
5 times, most recently
from
9afff29 to
1fcc862
Compare
NickVolynkin
commented
Jan 28, 2026
NickVolynkin
commented
Jan 28, 2026
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
3 times, most recently
from
141736a to
86c6f67
Compare
- Add an empty example report to ensure both dialogs can load. - Switch languages using TcxRadioButtons. TcxRadioButtons better represent application state than simple buttons. - Use the German localization language when application starts. Check the "German" radiobutton to reflect the default localization. - Group "Display Report" buttons into a labeled group, change captions. Move focus to "Display Report Designer" button when application starts. - Forbid to resize the application form. - Give the application a relevant title. - Use a DevExpress application icon. - Remove the Data Grid table. In this example, data structure is not in the focus of demonstration. Data Grid table draws attention from the localization examples. - Rename several interface components and code members according to DevExpress style. - Comment significant actions in the code example. Signed-off-by: Nick Volynkin <nikolay.volynkin@devexpress.com> Co-authored-by: Vladimir Abadzhev <vladimira@devexpress.com>
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
6 times, most recently
from
10050e6 to
9876597
Compare
- Add an empty example report to ensure both dialogs can load. - Switch languages using TcxRadioButtons. TcxRadioButtons better represent application state than simple buttons. - Use the German localization language when application starts. Check the "German" radiobutton to reflect the default localization. - Group "Display Report" buttons into a labeled group, change captions. Move focus to "Display Report Designer" button when application starts. - Forbid to resize the application form. - Give the application a relevant title. - Use a DevExpress application icon. - Remove the Data Grid table. In this example, data structure is not in the focus of demonstration. Data Grid table draws attention from the localization examples. - Rename several interface components and code members according to DevExpress style. - Comment significant actions in the code example. Signed-off-by: Nick Volynkin <nikolay.volynkin@devexpress.com> Co-authored-by: Vladimir Abadzhev <vladimira@devexpress.com>
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
2 times, most recently
from
f25972c to
17ea157
Compare
NickVolynkin
changed the title
- Explain the localization mechanism in more detail. - Add screenshots of localized Report Designer and Report viewer. - Add links to documentation - Give an overview of files with relevant code Signed-off-by: Nick Volynkin <nikolay.volynkin@devexpress.com> Co-authored-by: Vladimir Abadzhev <vladimira@devexpress.com> Co-authored-by: Dmitry Eliseev <dmitry.eliseev@devexpress.com> Co-authored-by: Albert Totten <49917542+albertov05@users.noreply.github.com>
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
3 times, most recently
from
7e56d50 to
5b29891
Compare
NickVolynkin
force-pushed
the
volynkin-restructure-readme
branch
from
5b29891 to
8c4f4bf
Compare
Contributor
Author
|
Reopened from a local (non-fork) branch in #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readme: Explain example purpose and restructure
Readme preview: https://github.com/NickVolynkin/vcl-reports-localize/blob/volynkin-restructure-readme/README.md
delphi/cpp-builder: Focus the example on DevExpress Reports localization
TcxRadioButtons better represent application state than simple buttons.
Check the "German" radiobutton to reflect the default localization.
Move focus to "Display Report Designer" button when application starts.
In this example, data structure is not in the focus of demonstration.
Data Grid table draws attention from the localization examples.
DevExpress style.