chore(): add adr for the mapping DSL (Domain Specific Language)#47
Merged
brandPittCode merged 14 commits intomainfrom May 4, 2026
Merged
chore(): add adr for the mapping DSL (Domain Specific Language)#47brandPittCode merged 14 commits intomainfrom
brandPittCode merged 14 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Architecture Decision Record (ADR) documenting the project’s decision to use JSLT as the dynamic mapping DSL for IDP-Core, including rationale, tradeoffs, and comparisons to JQ-based alternatives.
Changes:
- Adds ADR 0004 detailing the decision, decision drivers, consequences, and option analysis.
- Updates the Vale IDP vocabulary accept list to accommodate newly introduced terms.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
docs/src/contributing/adrs/0004-dynamic-mapping-dsl.md |
New ADR documenting the dynamic mapping DSL decision (JSLT vs JQ), including examples and pros/cons. |
.vale/styles/config/vocabularies/IDP/accept.txt |
Adds vocabulary entries to satisfy Vale linting for new documentation terms. |
etiennej70
reviewed
Apr 30, 2026
Collaborator
etiennej70
left a comment
etiennej70
left a comment
There was a problem hiding this comment.
✅ OK with the decision outcome, see few comments more about the formulation.
Great job.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Etienne JACQUOT <2057151+etiennej70@users.noreply.github.com> Signed-off-by: Andrés Brand <andresbrand@gmail.com>
Co-authored-by: Etienne JACQUOT <2057151+etiennej70@users.noreply.github.com> Signed-off-by: Andrés Brand <andresbrand@gmail.com>
|
evebrnd
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
What this PR Provides
This pull request adds a new Architecture Decision Record (ADR) documenting the selection of JSLT as the dynamic mapping DSL for the project. The ADR provides a thorough analysis of the options considered and the rationale for the decision.
Key additions in the ADR:
Dynamic Mapping DSL Decision:
Fixes
Review
The reviewer must double-check these points:
How to test
Breaking changes (if any)
Context of the Breaking Change
Result of the Breaking Change