feat(core)!: add entity post and path by RVANDO12 · Pull Request #23 · Decathlon/internal-developer-platform

RVANDO12 · 2026-04-10T14:45:37Z

PR Description

What this PR Provides

need #19 before

full post entity endpoint created

Update static swagger, and test containers

How to test

call GET /api/v1/entity-templates to get a template identifier
call POST /api/v1/entities/{template-identifier}

201 | Entity created successfully
404 | Template not found with identifier:
409 | Conflict, entity always exist
400 | name and identifier of entity is mandatory
400 | if exist in body, relastions must have name and target_entity_identifiers not empty

call
/api/v1/entity-templates?page=0&size=20&sort=identifier%2Casc' \

to get template list

get one without properties or relations

{
  "identifier": "data-pipeline",
  "name": "Data Pipeline",
  "description": "Template for data processing pipelines",
  "properties_definitions": [],
  "relations_definitions": []
}

and one with rules defined on it

{
  "identifier": "web-service",
  "name": "Web Service",
  "description": "Template for REST API web services",
  "properties_definitions": [
    {
      "name": "applicationName",
      "description": "Name of the application",
      "type": "STRING",
      "required": true,
      "rules": {
        "id": "550e8400-e29b-41d4-a716-446655440003",
        "format": null,
        "enum_values": null,
        "regex": "^[a-zA-Z0-9-]+$",
        "max_length": 50,
        "min_length": 3,
        "max_value": null,
        "min_value": null
      }
    },
    {
      "name": "baseUrl",
      "description": "Base URL for the service",
      "type": "STRING",
      "required": true,
      "rules": {
        "id": "550e8400-e29b-41d4-a716-446655440004",
        "format": "URL",
        "enum_values": null,
        "regex": "^https?://.*",
        "max_length": 255,
        "min_length": 8,
        "max_value": null,
        "min_value": null
      }
...
}

get entities from each :
data-pipeline

{
  "content": [],
  "page": {
    "size": 20,
    "number": 0,
    "total_elements": 0,
    "total_pages": 0
  }
}

monitoring-service

  {
    "content": [
      {
        "identifier": "monitoring-service-1",
        "name": "Monitoring Service 1",
        "properties": {},
        "relations": {},
        "relations_as_target": {},
        "template_identifier": "monitoring-service"
      },
      {
        "identifier": "monitoring-service-2",
        "name": "Monitoring Service 2",
        "properties": {},
        "relations": {},
        "relations_as_target": {},
        "template_identifier": "monitoring-service"
      },
      {
        "identifier": "monitoring-service-3",
        "name": "Monitoring Service 3",
        "properties": {},
        "relations": {},
        "relations_as_target": {},
        "template_identifier": "monitoring-service"
      },
      {
        "identifier": "monitoring-service-4",
        "name": "Monitoring Service 4",
        "properties": {},
        "relations": {},
        "relations_as_target": {},
        "template_identifier": "monitoring-service"
      },
      {
        "identifier": "monitoring-service-5",
        "name": "Monitoring Service 5",
        "properties": {},
        "relations": {},
        "relations_as_target": {},
        "template_identifier": "monitoring-service"
      },
      {
        "identifier": "monitoring-service-6",
        "name": "Monitoring Service 6",
        "properties": {},
        "relations": {},
        "relations_as_target": {},
        "template_identifier": "monitoring-service"
      }
    ],
    "page": {
      "size": 20,
      "number": 0,
      "total_elements": 6,
      "total_pages": 1
    }
  }

try to create entity for each :
data-pipeline :

curl -X 'POST' \
  'http://localhost:8084/api/v1/entities/data-pipeline' \
  -H 'accept: */*' \
  -H 'Content-Type: application/json' \
  -d '{
  "name": "data-001",
  "identifier": "data-001",
  "properties": {
    "type": "SQL",
    "environment": "dev"
  },
  "relations": [  ]
}'

201 entity created

trying call get :

curl -X 'GET' \
  'http://localhost:8084/api/v1/entities/data-pipeline?page=0&size=20&sort=identifier%2Casc' \
  -H 'accept: */*'


  
  {
    "content": [
      {
        "identifier": "data-001",
        "name": "data-001",
        "properties": {
          "environment": "dev",
          "type": "SQL"
        },
        "relations": {
          "depends-on": []
        },
        "relations_as_target": {},
        "template_identifier": "data-pipeline"
      }
    ],
    "page": {
      "size": 20,
      "number": 0,
      "total_elements": 1,
      "total_pages": 1
    }
  }

try to post same thing two time :

{
  "error": "CONFLICT",
  "error_description": "Entity with name 'data-001' already exists for template 'data-pipeline'"
}

Call new one with relations from previous :

{
  "name": "data-021",
  "identifier": "data-021",
  "properties": {
    "type": "SQL",
    "environment": "dev"
  },
  "relations": [
    {
      "name": "depends-on",
      "target_entity_identifiers": [
        "data-001"
      ]
    }
  ]
}

and get :

  {
    "content": [
      {
        "identifier": "data-001",
        "name": "data-001",
        "properties": {
          "environment": "dev",
          "type": "SQL"
        },
        "relations": {
          "depends-on": []
        },
        "relations_as_target": {
          "depends-on": [
            {
              "identifier": "data-021",
              "name": "data-021"
            }
          ]
        },
        "template_identifier": "data-pipeline"
      },
      {
        "identifier": "data-021",
        "name": "data-021",
        "properties": {
          "environment": "dev",
          "type": "SQL"
        },
        "relations": {
          "depends-on": [
            {
              "identifier": "data-001",
              "name": "data-001"
            }
          ]
        },
        "relations_as_target": {},
        "template_identifier": "data-pipeline"
      }
    ],
    "page": {
      "size": 20,
      "number": 0,
      "total_elements": 2,
      "total_pages": 1
    }
  }

try on one with rules :

  curl -X 'POST' \
    'http://localhost:8084/api/v1/entities/web-service' \
    -H 'accept: */*' \
    -H 'Content-Type: application/json' \
    -d '{
    "name": "data-test1",
    "identifier": "data-test1",
    "properties": {
      "applicationName": 12
    },
    "relations": [
    ]
  }'


  
  {
  "error": "BAD_REQUEST",
  "error_description": "Entity validation failed: Property 'applicationName' must be of type STRING; Property 'baseUrl' is required by template 'web-service'; Property 'environment' is required by template 'web-service'; Property 'ownerEmail' is required by template 'web-service'; Property 'port' is required by template 'web-service'; Property 'programmingLanguage' is required by template 'web-service'; Property 'protocol' is required by template 'web-service'; Property 'teamName' is required by template 'web-service'; Property 'version' is required by template 'web-service'"
  }

Breaking changes (if any)

Modify post entity and entity validation
add mock for local test

change unique constraint key on identifier =>

ALTER TABLE entity DROP CONSTRAINT entity_identifier_key;

ALTER TABLE entity ADD CONSTRAINT entity_identifier_template_identifier_key
    UNIQUE (identifier, template_identifier);

Context of the Breaking Change

For example: we redefined the component types list in the DPAC referential

Result of the Breaking Change

For example: your component of type xxx will migrate to the type yyy

brandPittCode · 2026-05-04T14:33:39Z

+    @Transactional
    public Entity createEntity(@Valid Entity entity) {
-        // Add validations
+        entityValidationService.checkTemplateExist(entity.templateIdentifier());


update for entityValidationService.validateForCreate

brandPittCode · 2026-05-04T14:34:56Z

+    /// Check entity template existence to ensure valid template reference before deeper validations.
+    /// @param entity the entity whose template existence is to be checked
+    /// @throws EntityTemplateNotFoundException if the template referenced by the entity does not exist
+    void checkTemplateExist(final String entity) {


Remove this and use EntityTemplateValidation.validateIfExists i the EntityService

brandPittCode · 2026-05-04T14:37:12Z

+        }
+    }
+
+    private void validateEntityHeader(Entity entity, Violations violations) {


This is already validated using the annotations in the Entity record.

brandPittCode · 2026-05-04T14:41:40Z

+    /// Checks for existing entity with same template and identifier to prevent duplicates.
+    /// @param entity the entity to check for existence
+    /// @throws EntityAlreadyExistsException if an entity with the same template and identifier already exists
+    void checkEntityAlreadyExist(final Entity entity) {


Suggested change

void checkEntityAlreadyExist(final Entity entity) {

void validateUniqueness(final Entity entity) {

brandPittCode · 2026-05-04T15:18:04Z

-    String value
+    String value,
+
+    Object rawValue


Lets's check if it we can get around without this parameter using only casting validation.

I would prefer keeping the Property model limited to business-related information and handling validation via casting, even if certain cases—like a numeric string—might pass through.

brandPittCode · 2026-05-04T15:24:31Z

+        violations.addIfBlank(entity.identifier(), ENTITY_IDENTIFIER_MANDATORY);
+    }
+
+    private void validatePropertiesShape(List<Property> properties, Violations violations) {


Do we rally need this. Isn't performed also by the annotations?

sonarqubecloud · 2026-05-05T14:33:52Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

brandPittCode · 2026-05-05T14:34:53Z

+            throw new EntityAlreadyExistsException(entity.templateIdentifier(), entity.identifier());
+        }
+    }
+}


Do we really need this validations?

RVANDO12 force-pushed the feat/entity/post branch 2 times, most recently from b9987ed to 59810a8 Compare April 24, 2026 12:05

RVANDO12 changed the title ~~chore(feat): add entity post and path~~ feat(core): add entity post and path Apr 24, 2026

RVANDO12 force-pushed the feat/entity/post branch 3 times, most recently from edaf96e to 99c4786 Compare April 24, 2026 12:22

RVANDO12 marked this pull request as ready for review April 24, 2026 12:22

RVANDO12 force-pushed the feat/entity/post branch 5 times, most recently from ea6834b to dacabf1 Compare April 28, 2026 13:20

brandPittCode reviewed Apr 28, 2026

View reviewed changes

Comment thread src/main/java/com/decathlon/idp_core/domain/port/EntityRepositoryPort.java

brandPittCode requested changes Apr 28, 2026

View reviewed changes

RVANDO12 changed the title ~~feat(core): add entity post and path~~ feat(core)!: add entity post and path Apr 29, 2026

github-advanced-security AI found potential problems Apr 30, 2026

View reviewed changes

Comment thread .../decathlon/idp_core/infrastructure/adapters/api/configuration/MockSecurityConfiguration.java Fixed

RVANDO12 force-pushed the feat/entity/post branch 3 times, most recently from c018c8c to ddb79e0 Compare May 4, 2026 06:50

feat(core): add post entity

d807c69

RVANDO12 force-pushed the feat/entity/post branch from ddb79e0 to d807c69 Compare May 4, 2026 06:58

RVANDO12 added 4 commits May 4, 2026 09:23

feat(core): fix sonar issue and copilot review

e26e26c

feat(core): fix sonar review

fd1b354

feat(core): fix sonar qube and test

a859554

feat(core): fix validation type check

3958089

brandPittCode reviewed May 4, 2026

View reviewed changes

Comment thread src/main/java/com/decathlon/idp_core/domain/service/entity/EntityService.java Outdated

brandPittCode reviewed May 4, 2026

View reviewed changes

brandPittCode requested changes May 4, 2026

View reviewed changes

RVANDO12 added 2 commits May 5, 2026 16:13

feat(core): fix review

fb272c2

feat(core): fix end of file

6f466d6

brandPittCode reviewed May 5, 2026

View reviewed changes

	void checkEntityAlreadyExist(final Entity entity) {
	void validateUniqueness(final Entity entity) {

Conversation

RVANDO12 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

What this PR Provides

How to test

Breaking changes (if any)

Context of the Breaking Change

Result of the Breaking Change

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brandPittCode May 4, 2026

Choose a reason for hiding this comment

Uh oh!

brandPittCode May 4, 2026

Choose a reason for hiding this comment

Uh oh!

brandPittCode May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brandPittCode May 4, 2026

Choose a reason for hiding this comment

Uh oh!

brandPittCode May 4, 2026

Choose a reason for hiding this comment

Uh oh!

brandPittCode May 5, 2026

Choose a reason for hiding this comment

Uh oh!

brandPittCode May 4, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 5, 2026

Quality Gate passed

Uh oh!

brandPittCode May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RVANDO12 commented Apr 10, 2026 •

edited

Loading

brandPittCode May 4, 2026 •

edited

Loading