Ensures destroy and restore operations are wrapped in a transaction that is rolled back when the callback chain is halted#71
Open
alecdotninja wants to merge 2 commits intoDavyJonesLocker:masterfrom
alecdotninja:transaction_support
Open
Ensures destroy and restore operations are wrapped in a transaction that is rolled back when the callback chain is halted#71alecdotninja wants to merge 2 commits intoDavyJonesLocker:masterfrom alecdotninja:transaction_support
alecdotninja wants to merge 2 commits intoDavyJonesLocker:masterfrom
alecdotninja:transaction_support
Conversation
…hat is rolled back when the callback chain is halted
Contributor
Author
|
Coincidently, this also solves #56. |
Contributor
|
Thank you for the PR @anarchocurious, and I apologize for the delay in getting merged in. It looks like this branch needs to be rebased, as we have a conflict based off of the work in ae82efb. Please ping me when you have a chance to rebase and I will get this merged in. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch,
DestroyedAt#destroydoes not roll back the transaction when the callback chain is halted. This deviates from the standard ActiveRecord behavior and breaks several features. It is particularly dangerous for associations usingdependent: :restrict_with_errorwhich are silently destroyed.The same semantics have been extended to
DestroyedAt#restore. I've also added aDestroyedAt#restore!and corresponding error class (DestroyedAt::RecordNotRestored) to mimicActiveRecord::Base#destroy!and friends.