Skip to content

Client refactor #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marek55S wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Client refactor #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aabb674
feat: add file validation and image conversion utilities
Marek55S Feb 15, 2026
2764cb4
feat: implement file upload and image processing hooks
Marek55S Feb 16, 2026
ed3191c
refactor: simplify ImageConverter component and enhance file upload h…
Marek55S Feb 17, 2026
a1d8a9f
refactor: remove onFileReject prop and handle file rejection locally …
Marek55S Mar 2, 2026
2aeeb2e
fixed image preview cleanup
Marek55S Mar 2, 2026
3470c7a
fix: improve error message formatting and reset local error state in …
Marek55S Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions client/src/components/common/DragAndDropZone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import { useDropzone } from 'react-dropzone';
import type { FileRejection, Accept } from 'react-dropzone';
import { useEffect, useRef, useState, useCallback } from 'preact/hooks';
import type { ComponentChildren, RefObject } from 'preact';
import { formatRejectionReasons } from '@/utils/fileValidation';

type DragAndDropZoneProps = {
onFileDrop: (file: File) => void | Promise<void>;
onFileReject?: (rejectedFiles: FileRejection[]) => void;
accept?: Accept;
multiple?: boolean;
className?: string;
Expand All @@ -15,7 +15,6 @@ type DragAndDropZoneProps = {

const DragAndDropZone = ({
onFileDrop,
onFileReject,
accept,
multiple = false,
className = '',
Expand Down Expand Up @@ -47,13 +46,16 @@ const DragAndDropZone = ({
});
}, [overlayTargetRef]);

const [localError, setLocalError] = useState<string | undefined>();

const { getRootProps, getInputProps, isDragActive } = useDropzone({
accept,
multiple,
noClick: true,
maxFiles: multiple ? undefined : 1,
onDropAccepted: async (files) => {
try {
setLocalError(undefined);
if (multiple) {
for (const file of files) {
await onFileDrop(file);
Expand All @@ -67,14 +69,13 @@ const DragAndDropZone = ({
}
},
onDropRejected: (rejectedFiles) => {
if (!onFileReject) return;
try {
onFileReject(rejectedFiles);
} catch (error) {
console.error('Error handling rejected files:', error);
}
if (rejectedFiles.length === 0) return;
setLocalError(`Rejected: ${formatRejectionReasons(rejectedFiles)}`);
},
Comment on lines 69 to 74
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localError is set on onDropRejected, but it is never cleared on a subsequent successful drop, so the rejection banner can persist even after the user uploads a valid file. Clear localError in onDropAccepted (and/or when a new drag starts) so the UI reflects the current state.

Copilot uses AI. Check for mistakes.
onDragEnter: () => {
setLocalError(undefined);
updateOverlayRect();
},
onDragEnter: () => updateOverlayRect(),
});

// react-dropzone returns props typed for React — we cast them for Preact
Expand Down Expand Up @@ -148,6 +149,12 @@ const DragAndDropZone = ({
className="bg-orange-100/60 border-2 border-orange-400 rounded-md pointer-events-none"
/>
)}

{localError && (
<div className="absolute bottom-2 left-2 right-2 text-xs text-red-600 bg-red-50 p-2 rounded border border-red-200 z-20">
{localError}
</div>
)}
</div>
);
};
Expand Down
Loading
Loading