Skip to content

Conversation

@hugoqnc
Copy link
Contributor

@hugoqnc hugoqnc commented Jan 27, 2026

What does this PR do? What is the motivation?

  • Update documentation of security trigger to include Security Findings (in addition to Signals). Also include that workflows can be manually triggered from Misconfiguration & Identity Risk side panels.
  • Update the "Build a workflow" examples to use the right field paths, and remove the unnecessary step of using the Get security finding action when using the Security trigger.
    • Note: these new paths were introduced with this PR

Merge instructions

Merge readiness:

  • Ready for merge

@hugoqnc hugoqnc requested a review from a team as a code owner January 27, 2026 13:21
@github-actions
Copy link
Contributor

Copy link

@alex147 alex147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, the rest looks good 👌🏼

Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback! Give that a review and let me know if you have any questions. Ping me when ready for re-review!

### Security Notification Rule triggers

You can set up a workflow to trigger every time a Security Signal Notification Rule fires.
You can set up a workflow to trigger every time a Security Notification Rule fires, for both Security Signals and Security Findings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a little confusing to me. Is this what you mean?

Suggested change
You can set up a workflow to trigger every time a Security Notification Rule fires, for both Security Signals and Security Findings.
You can set up a workflow to trigger when a Security Notification Rule generates a Security Signal or Security Finding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right it wasn't clear, though a notification rule doesn't really "generate" a Signal or Finding, it just notifies on a detected Signal or Finding. I replaced it with:

- You can set up a workflow to trigger every time a Security Notification Rule fires, for both Security Signals and Security Findings.
+ You can set up a workflow to trigger whenever a Security Notification Rule sends a notification for either a Security Signal or a Security Finding.

hugoqnc and others added 2 commits January 28, 2026 10:46
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes! Committed a few final tiny tweaks. We're good to go :)

@hugoqnc hugoqnc merged commit e58539b into master Jan 29, 2026
16 checks passed
@hugoqnc hugoqnc deleted the hugo.queinnec/update-workflow-doc-for-security branch January 29, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants