-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[SEC-27555] Update documentation of workflows for security findings #34157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEC-27555] Update documentation of workflows for security findings #34157
Conversation
Preview links (active after the
|
alex147
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, the rest looks good 👌🏼
content/en/security/cloud_security_management/review_remediate/workflows.md
Show resolved
Hide resolved
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback! Give that a review and let me know if you have any questions. Ping me when ready for re-review!
| ### Security Notification Rule triggers | ||
|
|
||
| You can set up a workflow to trigger every time a Security Signal Notification Rule fires. | ||
| You can set up a workflow to trigger every time a Security Notification Rule fires, for both Security Signals and Security Findings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is a little confusing to me. Is this what you mean?
| You can set up a workflow to trigger every time a Security Notification Rule fires, for both Security Signals and Security Findings. | |
| You can set up a workflow to trigger when a Security Notification Rule generates a Security Signal or Security Finding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right it wasn't clear, though a notification rule doesn't really "generate" a Signal or Finding, it just notifies on a detected Signal or Finding. I replaced it with:
- You can set up a workflow to trigger every time a Security Notification Rule fires, for both Security Signals and Security Findings.
+ You can set up a workflow to trigger whenever a Security Notification Rule sends a notification for either a Security Signal or a Security Finding.
content/en/security/cloud_security_management/review_remediate/workflows.md
Outdated
Show resolved
Hide resolved
content/en/security/cloud_security_management/review_remediate/workflows.md
Outdated
Show resolved
Hide resolved
content/en/security/cloud_security_management/review_remediate/workflows.md
Outdated
Show resolved
Hide resolved
content/en/security/cloud_security_management/review_remediate/workflows.md
Outdated
Show resolved
Hide resolved
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes! Committed a few final tiny tweaks. We're good to go :)
What does this PR do? What is the motivation?
Merge instructions
Merge readiness: