Fix idempotency issue with tabletest formatter#11006
Fix idempotency issue with tabletest formatter#11006gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069129
Total [baseline] (8.906 s) : 0, 8905660
Agent [candidate] (1.063 s) : 0, 1063356
Total [candidate] (8.913 s) : 0, 8912706
section iast
Agent [baseline] (1.234 s) : 0, 1233820
Total [baseline] (9.582 s) : 0, 9581745
Agent [candidate] (1.235 s) : 0, 1234929
Total [candidate] (9.573 s) : 0, 9572630
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (635.621 ms) : 0, 635621
BytebuddyAgent [candidate] (631.947 ms) : 0, 631947
AgentMeter [baseline] (29.708 ms) : 0, 29708
AgentMeter [candidate] (29.447 ms) : 0, 29447
GlobalTracer [baseline] (258.78 ms) : 0, 258780
GlobalTracer [candidate] (257.886 ms) : 0, 257886
AppSec [baseline] (32.127 ms) : 0, 32127
AppSec [candidate] (31.893 ms) : 0, 31893
Debugger [baseline] (60.118 ms) : 0, 60118
Debugger [candidate] (59.641 ms) : 0, 59641
Remote Config [baseline] (591.289 µs) : 0, 591
Remote Config [candidate] (587.422 µs) : 0, 587
Telemetry [baseline] (8.156 ms) : 0, 8156
Telemetry [candidate] (8.123 ms) : 0, 8123
Flare Poller [baseline] (6.486 ms) : 0, 6486
Flare Poller [candidate] (6.43 ms) : 0, 6430
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (800.656 ms) : 0, 800656
BytebuddyAgent [candidate] (801.429 ms) : 0, 801429
AgentMeter [baseline] (11.53 ms) : 0, 11530
AgentMeter [candidate] (11.46 ms) : 0, 11460
GlobalTracer [baseline] (249.561 ms) : 0, 249561
GlobalTracer [candidate] (248.932 ms) : 0, 248932
AppSec [baseline] (26.585 ms) : 0, 26585
AppSec [candidate] (27.473 ms) : 0, 27473
Debugger [baseline] (68.79 ms) : 0, 68790
Debugger [candidate] (66.211 ms) : 0, 66211
Remote Config [baseline] (527.783 µs) : 0, 528
Remote Config [candidate] (528.54 µs) : 0, 529
Telemetry [baseline] (9.652 ms) : 0, 9652
Telemetry [candidate] (11.823 ms) : 0, 11823
Flare Poller [baseline] (3.561 ms) : 0, 3561
Flare Poller [candidate] (4.169 ms) : 0, 4169
IAST [baseline] (25.57 ms) : 0, 25570
IAST [candidate] (25.439 ms) : 0, 25439
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068664
Total [baseline] (11.166 s) : 0, 11165518
Agent [candidate] (1.073 s) : 0, 1073342
Total [candidate] (11.137 s) : 0, 11137440
section appsec
Agent [baseline] (1.251 s) : 0, 1250703
Total [baseline] (11.178 s) : 0, 11177680
Agent [candidate] (1.252 s) : 0, 1251661
Total [candidate] (11.161 s) : 0, 11160654
section iast
Agent [baseline] (1.237 s) : 0, 1237015
Total [baseline] (11.37 s) : 0, 11370212
Agent [candidate] (1.234 s) : 0, 1233646
Total [candidate] (11.482 s) : 0, 11481670
section profiling
Agent [baseline] (1.188 s) : 0, 1188332
Total [baseline] (11.034 s) : 0, 11034270
Agent [candidate] (1.196 s) : 0, 1195780
Total [candidate] (11.012 s) : 0, 11011749
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.246 ms) : 0, 1246
BytebuddyAgent [baseline] (635.213 ms) : 0, 635213
BytebuddyAgent [candidate] (639.558 ms) : 0, 639558
AgentMeter [baseline] (29.699 ms) : 0, 29699
AgentMeter [candidate] (29.947 ms) : 0, 29947
GlobalTracer [baseline] (259.507 ms) : 0, 259507
GlobalTracer [candidate] (261.07 ms) : 0, 261070
AppSec [baseline] (32.451 ms) : 0, 32451
AppSec [candidate] (32.033 ms) : 0, 32033
Debugger [baseline] (61.253 ms) : 0, 61253
Debugger [candidate] (60.789 ms) : 0, 60789
Remote Config [baseline] (594.34 µs) : 0, 594
Remote Config [candidate] (590.117 µs) : 0, 590
Telemetry [baseline] (8.087 ms) : 0, 8087
Telemetry [candidate] (8.115 ms) : 0, 8115
Flare Poller [baseline] (4.371 ms) : 0, 4371
Flare Poller [candidate] (3.559 ms) : 0, 3559
section appsec
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (660.494 ms) : 0, 660494
BytebuddyAgent [candidate] (660.731 ms) : 0, 660731
AgentMeter [baseline] (12.161 ms) : 0, 12161
AgentMeter [candidate] (12.219 ms) : 0, 12219
GlobalTracer [baseline] (259.063 ms) : 0, 259063
GlobalTracer [candidate] (259.848 ms) : 0, 259848
AppSec [baseline] (178.04 ms) : 0, 178040
AppSec [candidate] (178.062 ms) : 0, 178062
Debugger [baseline] (66.555 ms) : 0, 66555
Debugger [candidate] (65.571 ms) : 0, 65571
Remote Config [baseline] (650.236 µs) : 0, 650
Remote Config [candidate] (641.829 µs) : 0, 642
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (8.361 ms) : 0, 8361
Flare Poller [baseline] (3.652 ms) : 0, 3652
Flare Poller [candidate] (4.432 ms) : 0, 4432
IAST [baseline] (24.25 ms) : 0, 24250
IAST [candidate] (24.204 ms) : 0, 24204
section iast
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (803.741 ms) : 0, 803741
BytebuddyAgent [candidate] (799.615 ms) : 0, 799615
AgentMeter [baseline] (11.695 ms) : 0, 11695
AgentMeter [candidate] (11.423 ms) : 0, 11423
GlobalTracer [baseline] (248.222 ms) : 0, 248222
GlobalTracer [candidate] (248.578 ms) : 0, 248578
AppSec [baseline] (27.558 ms) : 0, 27558
AppSec [candidate] (27.683 ms) : 0, 27683
Debugger [baseline] (69.077 ms) : 0, 69077
Debugger [candidate] (67.368 ms) : 0, 67368
Remote Config [baseline] (528.127 µs) : 0, 528
Remote Config [candidate] (536.47 µs) : 0, 536
Telemetry [baseline] (9.684 ms) : 0, 9684
Telemetry [candidate] (11.346 ms) : 0, 11346
Flare Poller [baseline] (3.512 ms) : 0, 3512
Flare Poller [candidate] (4.019 ms) : 0, 4019
IAST [baseline] (25.48 ms) : 0, 25480
IAST [candidate] (25.658 ms) : 0, 25658
section profiling
ProfilingAgent [baseline] (94.408 ms) : 0, 94408
ProfilingAgent [candidate] (94.125 ms) : 0, 94125
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (686.177 ms) : 0, 686177
BytebuddyAgent [candidate] (691.195 ms) : 0, 691195
AgentMeter [baseline] (9.037 ms) : 0, 9037
AgentMeter [candidate] (9.068 ms) : 0, 9068
GlobalTracer [baseline] (215.643 ms) : 0, 215643
GlobalTracer [candidate] (217.332 ms) : 0, 217332
AppSec [baseline] (32.452 ms) : 0, 32452
AppSec [candidate] (32.685 ms) : 0, 32685
Debugger [baseline] (66.372 ms) : 0, 66372
Debugger [candidate] (66.677 ms) : 0, 66677
Remote Config [baseline] (579.508 µs) : 0, 580
Remote Config [candidate] (591.448 µs) : 0, 591
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.84 ms) : 0, 7840
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.531 ms) : 0, 3531
Profiling [baseline] (94.965 ms) : 0, 94965
Profiling [candidate] (94.673 ms) : 0, 94673
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section baseline
no_agent (1.243 ms) : 1231, 1256
. : milestone, 1243,
iast (3.366 ms) : 3320, 3411
. : milestone, 3366,
iast_FULL (5.83 ms) : 5772, 5888
. : milestone, 5830,
iast_GLOBAL (3.717 ms) : 3656, 3778
. : milestone, 3717,
profiling (2.242 ms) : 2221, 2263
. : milestone, 2242,
tracing (1.858 ms) : 1842, 1875
. : milestone, 1858,
section candidate
no_agent (1.25 ms) : 1237, 1264
. : milestone, 1250,
iast (3.481 ms) : 3430, 3533
. : milestone, 3481,
iast_FULL (6.192 ms) : 6129, 6256
. : milestone, 6192,
iast_GLOBAL (3.728 ms) : 3667, 3789
. : milestone, 3728,
profiling (2.071 ms) : 2051, 2090
. : milestone, 2071,
tracing (1.838 ms) : 1822, 1853
. : milestone, 1838,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section baseline
no_agent (19.023 ms) : 18831, 19215
. : milestone, 19023,
appsec (18.546 ms) : 18363, 18729
. : milestone, 18546,
code_origins (17.927 ms) : 17750, 18104
. : milestone, 17927,
iast (17.949 ms) : 17770, 18128
. : milestone, 17949,
profiling (20.843 ms) : 20638, 21048
. : milestone, 20843,
tracing (17.467 ms) : 17296, 17637
. : milestone, 17467,
section candidate
no_agent (17.925 ms) : 17744, 18106
. : milestone, 17925,
appsec (18.527 ms) : 18341, 18714
. : milestone, 18527,
code_origins (18.086 ms) : 17910, 18262
. : milestone, 18086,
iast (18.007 ms) : 17830, 18185
. : milestone, 18007,
profiling (18.388 ms) : 18205, 18570
. : milestone, 18388,
tracing (18.92 ms) : 18733, 19108
. : milestone, 18920,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.826 ms) : 3602, 4050
. : milestone, 3826,
iast (2.277 ms) : 2208, 2346
. : milestone, 2277,
iast_GLOBAL (2.311 ms) : 2242, 2380
. : milestone, 2311,
profiling (2.097 ms) : 2043, 2152
. : milestone, 2097,
tracing (2.099 ms) : 2045, 2153
. : milestone, 2099,
section candidate
no_agent (1.492 ms) : 1480, 1504
. : milestone, 1492,
appsec (3.849 ms) : 3627, 4070
. : milestone, 3849,
iast (2.271 ms) : 2202, 2339
. : milestone, 2271,
iast_GLOBAL (2.323 ms) : 2253, 2392
. : milestone, 2323,
profiling (2.11 ms) : 2054, 2166
. : milestone, 2110,
tracing (2.084 ms) : 2030, 2137
. : milestone, 2084,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~8f5f7acf02, baseline=1.61.0-SNAPSHOT~b7fb6fc123
dateFormat X
axisFormat %s
section baseline
no_agent (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
appsec (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
iast (17.78 s) : 17780000, 17780000
. : milestone, 17780000,
iast_GLOBAL (18.251 s) : 18251000, 18251000
. : milestone, 18251000,
profiling (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
tracing (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
section candidate
no_agent (15.489 s) : 15489000, 15489000
. : milestone, 15489000,
appsec (14.587 s) : 14587000, 14587000
. : milestone, 14587000,
iast (18.45 s) : 18450000, 18450000
. : milestone, 18450000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
profiling (15.044 s) : 15044000, 15044000
. : milestone, 15044000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
8ae02b1
into
master
What Does This Do
tableTestFormatterandgoogleJavaFormatwere declared in the wrong order ingradle/spotless.gradle.Spotless applies formatters sequentially, so the last one wins.
With GJF declared first and TF second, GJF changed
@TableTestannotation array indentation from 4-space to 6-space, and TF ran after but only re-aligned column widths it did not restore the 4-space indentation. This left the files in 6-space, which is a different state than what TF itself would write, causing a non-idempotent cycle.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.