Fix DD_APM_TRACING_ENABLED to work with LLMObs#10989
Open
matsumo-and wants to merge 4 commits intoDataDog:masterfrom
Open
Fix DD_APM_TRACING_ENABLED to work with LLMObs#10989matsumo-and wants to merge 4 commits intoDataDog:masterfrom
matsumo-and wants to merge 4 commits intoDataDog:masterfrom
Conversation
Signed-off-by: matsumo-and <yh134.toisanda@gmail.com>
Fixes DataDog#10051 When DD_APM_TRACING_ENABLED=false is set, APM tracing should be disabled while allowing other products like LLM Observability to function. Previously, setting DD_APM_TRACING_ENABLED=false would inadvertently disable LLMObs or allow APM traces to leak through when no other products were enabled. Signed-off-by: matsumo-and <yh134.toisanda@gmail.com>
Signed-off-by: matsumo-and <yh134.toisanda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR fixes two issues when using LLM Observability without APM tracing:
DD_APM_TRACING_ENABLED=falseproperly drop APM traces while keeping LLMObs tracesNullPointerExceptionwhenDD_TRACE_ENABLED=falseis set with LLMObs enabledMotivation
Solves #10051
Currently, when
DD_APM_TRACING_ENABLED=falseis set withDD_LLMOBS_ENABLED=true, APM traces are still sent to the agent because the sampler selection logic falls through to the default sampler, which keeps all traces by default.Additionally, setting
DD_TRACE_ENABLED=falsecauses NPE in LLMObs methods because LLMObs tries to initialize even when all tracing is disabled.Additional Notes
Implementation approach:
TraceSegment.setTagTop()to propagate the LLMOBS flag from child spans to the root span, following the exact same pattern used by ASM (AppSecEventTracker, GatewayBridge, IAST Reporter)LlmObsStandaloneSamplerwhenDD_APM_TRACING_ENABLED=falseandDD_LLMOBS_ENABLED=trueLLMObsSystem.start()when!config.isTraceEnabled()Testing:
dd-smoke-tests/apm-tracing-disabled/Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueNote: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.