-
Notifications
You must be signed in to change notification settings - Fork 323
Refactor manual array copy to system function. #10329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexeyKuznetsov-DD
wants to merge
1
commit into
master
Choose a base branch
from
alexeyk/refactor-manual-array-copy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087549
Total [baseline] (10.811 s) : 0, 10811072
Agent [candidate] (1.091 s) : 0, 1091314
Total [candidate] (10.862 s) : 0, 10862080
section appsec
Agent [baseline] (1.265 s) : 0, 1265362
Total [baseline] (10.972 s) : 0, 10972004
Agent [candidate] (1.262 s) : 0, 1261735
Total [candidate] (10.92 s) : 0, 10919888
section iast
Agent [baseline] (1.222 s) : 0, 1222196
Total [baseline] (11.134 s) : 0, 11134471
Agent [candidate] (1.221 s) : 0, 1221255
Total [candidate] (11.181 s) : 0, 11180708
section profiling
Agent [baseline] (1.21 s) : 0, 1210056
Total [baseline] (10.869 s) : 0, 10869181
Agent [candidate] (1.219 s) : 0, 1219243
Total [candidate] (10.957 s) : 0, 10956977
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (652.487 ms) : 0, 652487
BytebuddyAgent [candidate] (655.386 ms) : 0, 655386
GlobalTracer [baseline] (283.327 ms) : 0, 283327
GlobalTracer [candidate] (284.003 ms) : 0, 284003
AppSec [baseline] (32.801 ms) : 0, 32801
AppSec [candidate] (32.918 ms) : 0, 32918
Debugger [baseline] (68.89 ms) : 0, 68890
Debugger [candidate] (68.618 ms) : 0, 68618
Remote Config [baseline] (628.097 µs) : 0, 628
Remote Config [candidate] (618.1 µs) : 0, 618
Telemetry [baseline] (8.923 ms) : 0, 8923
Telemetry [candidate] (9.139 ms) : 0, 9139
Flare Poller [baseline] (3.732 ms) : 0, 3732
Flare Poller [candidate] (3.828 ms) : 0, 3828
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (691.36 ms) : 0, 691360
BytebuddyAgent [candidate] (688.69 ms) : 0, 688690
GlobalTracer [baseline] (257.804 ms) : 0, 257804
GlobalTracer [candidate] (256.922 ms) : 0, 256922
IAST [baseline] (24.613 ms) : 0, 24613
IAST [candidate] (24.487 ms) : 0, 24487
AppSec [baseline] (174.161 ms) : 0, 174161
AppSec [candidate] (173.472 ms) : 0, 173472
Debugger [baseline] (66.765 ms) : 0, 66765
Debugger [candidate] (67.639 ms) : 0, 67639
Remote Config [baseline] (781.456 µs) : 0, 781
Remote Config [candidate] (795.814 µs) : 0, 796
Telemetry [baseline] (9.478 ms) : 0, 9478
Telemetry [candidate] (9.536 ms) : 0, 9536
Flare Poller [baseline] (3.771 ms) : 0, 3771
Flare Poller [candidate] (3.769 ms) : 0, 3769
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (790.243 ms) : 0, 790243
BytebuddyAgent [candidate] (789.814 ms) : 0, 789814
GlobalTracer [baseline] (255.589 ms) : 0, 255589
GlobalTracer [candidate] (255.583 ms) : 0, 255583
IAST [baseline] (26.964 ms) : 0, 26964
IAST [candidate] (26.896 ms) : 0, 26896
AppSec [baseline] (33.374 ms) : 0, 33374
AppSec [candidate] (35.013 ms) : 0, 35013
Debugger [baseline] (66.856 ms) : 0, 66856
Debugger [candidate] (64.695 ms) : 0, 64695
Remote Config [baseline] (632.453 µs) : 0, 632
Remote Config [candidate] (598.358 µs) : 0, 598
Telemetry [baseline] (8.466 ms) : 0, 8466
Telemetry [candidate] (8.542 ms) : 0, 8542
Flare Poller [baseline] (3.582 ms) : 0, 3582
Flare Poller [candidate] (3.592 ms) : 0, 3592
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (706.813 ms) : 0, 706813
BytebuddyAgent [candidate] (711.931 ms) : 0, 711931
GlobalTracer [baseline] (221.431 ms) : 0, 221431
GlobalTracer [candidate] (222.747 ms) : 0, 222747
AppSec [baseline] (32.517 ms) : 0, 32517
AppSec [candidate] (32.652 ms) : 0, 32652
Debugger [baseline] (67.747 ms) : 0, 67747
Debugger [candidate] (68.726 ms) : 0, 68726
Remote Config [baseline] (647.477 µs) : 0, 647
Remote Config [candidate] (634.953 µs) : 0, 635
Telemetry [baseline] (8.839 ms) : 0, 8839
Telemetry [candidate] (8.809 ms) : 0, 8809
Flare Poller [baseline] (3.613 ms) : 0, 3613
Flare Poller [candidate] (3.716 ms) : 0, 3716
ProfilingAgent [baseline] (96.988 ms) : 0, 96988
ProfilingAgent [candidate] (98.223 ms) : 0, 98223
Profiling [baseline] (97.584 ms) : 0, 97584
Profiling [candidate] (98.81 ms) : 0, 98810
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096471
Total [baseline] (8.775 s) : 0, 8775335
Agent [candidate] (1.084 s) : 0, 1083772
Total [candidate] (8.738 s) : 0, 8737985
section iast
Agent [baseline] (1.221 s) : 0, 1221076
Total [baseline] (9.314 s) : 0, 9313731
Agent [candidate] (1.22 s) : 0, 1220364
Total [candidate] (9.28 s) : 0, 9280117
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (659.5 ms) : 0, 659500
BytebuddyAgent [candidate] (651.135 ms) : 0, 651135
GlobalTracer [baseline] (285.398 ms) : 0, 285398
GlobalTracer [candidate] (282.485 ms) : 0, 282485
AppSec [baseline] (33.02 ms) : 0, 33020
AppSec [candidate] (32.485 ms) : 0, 32485
Debugger [baseline] (68.032 ms) : 0, 68032
Debugger [candidate] (67.56 ms) : 0, 67560
Remote Config [baseline] (647.787 µs) : 0, 648
Remote Config [candidate] (642.196 µs) : 0, 642
Telemetry [baseline] (9.041 ms) : 0, 9041
Telemetry [candidate] (9.077 ms) : 0, 9077
Flare Poller [baseline] (3.775 ms) : 0, 3775
Flare Poller [candidate] (3.673 ms) : 0, 3673
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (788.061 ms) : 0, 788061
BytebuddyAgent [candidate] (789.868 ms) : 0, 789868
GlobalTracer [baseline] (256.476 ms) : 0, 256476
GlobalTracer [candidate] (255.371 ms) : 0, 255371
IAST [baseline] (27.177 ms) : 0, 27177
IAST [candidate] (27.06 ms) : 0, 27060
AppSec [baseline] (32.14 ms) : 0, 32140
AppSec [candidate] (33.455 ms) : 0, 33455
Debugger [baseline] (67.962 ms) : 0, 67962
Debugger [candidate] (65.514 ms) : 0, 65514
Remote Config [baseline] (601.921 µs) : 0, 602
Remote Config [candidate] (590.223 µs) : 0, 590
Telemetry [baseline] (8.568 ms) : 0, 8568
Telemetry [candidate] (8.517 ms) : 0, 8517
Flare Poller [baseline] (3.572 ms) : 0, 3572
Flare Poller [candidate] (3.555 ms) : 0, 3555
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section baseline
no_agent (17.457 ms) : 17279, 17636
. : milestone, 17457,
appsec (18.647 ms) : 18457, 18837
. : milestone, 18647,
code_origins (17.892 ms) : 17713, 18071
. : milestone, 17892,
iast (17.751 ms) : 17573, 17929
. : milestone, 17751,
profiling (18.676 ms) : 18490, 18862
. : milestone, 18676,
tracing (17.886 ms) : 17706, 18066
. : milestone, 17886,
section candidate
no_agent (19.066 ms) : 18867, 19265
. : milestone, 19066,
appsec (18.847 ms) : 18657, 19037
. : milestone, 18847,
code_origins (17.855 ms) : 17679, 18031
. : milestone, 17855,
iast (18.474 ms) : 18287, 18661
. : milestone, 18474,
profiling (19.699 ms) : 19495, 19903
. : milestone, 19699,
tracing (17.68 ms) : 17503, 17858
. : milestone, 17680,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1164, 1187
. : milestone, 1175,
iast (3.066 ms) : 3032, 3099
. : milestone, 3066,
iast_FULL (5.664 ms) : 5609, 5720
. : milestone, 5664,
iast_GLOBAL (3.659 ms) : 3593, 3726
. : milestone, 3659,
profiling (2.067 ms) : 2048, 2086
. : milestone, 2067,
tracing (1.746 ms) : 1732, 1761
. : milestone, 1746,
section candidate
no_agent (1.166 ms) : 1155, 1177
. : milestone, 1166,
iast (3.146 ms) : 3104, 3188
. : milestone, 3146,
iast_FULL (5.584 ms) : 5529, 5639
. : milestone, 5584,
iast_GLOBAL (3.601 ms) : 3548, 3654
. : milestone, 3601,
profiling (1.987 ms) : 1971, 2004
. : milestone, 1987,
tracing (1.76 ms) : 1746, 1774
. : milestone, 1760,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.469 ms) : 2417, 2521
. : milestone, 2469,
iast (2.207 ms) : 2142, 2272
. : milestone, 2207,
iast_GLOBAL (2.249 ms) : 2184, 2314
. : milestone, 2249,
profiling (2.079 ms) : 2025, 2133
. : milestone, 2079,
tracing (2.055 ms) : 2003, 2106
. : milestone, 2055,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.641 ms) : 3427, 3855
. : milestone, 3641,
iast (2.214 ms) : 2149, 2278
. : milestone, 2214,
iast_GLOBAL (2.256 ms) : 2191, 2321
. : milestone, 2256,
profiling (2.063 ms) : 2010, 2115
. : milestone, 2063,
tracing (2.023 ms) : 1972, 2073
. : milestone, 2023,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~2f082b7c9b, baseline=1.59.0-SNAPSHOT~e35d102bab
dateFormat X
axisFormat %s
section baseline
no_agent (15.035 s) : 15035000, 15035000
. : milestone, 15035000,
appsec (14.676 s) : 14676000, 14676000
. : milestone, 14676000,
iast (18.566 s) : 18566000, 18566000
. : milestone, 18566000,
iast_GLOBAL (17.699 s) : 17699000, 17699000
. : milestone, 17699000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (14.475 s) : 14475000, 14475000
. : milestone, 14475000,
section candidate
no_agent (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
appsec (14.607 s) : 14607000, 14607000
. : milestone, 14607000,
iast (18.761 s) : 18761000, 18761000
. : milestone, 18761000,
iast_GLOBAL (17.708 s) : 17708000, 17708000
. : milestone, 17708000,
profiling (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
tracing (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactor manual array copy to system function.
Motivation
Clean code
Additional Notes
Found by IDEA static analysis.