-
Notifications
You must be signed in to change notification settings - Fork 323
Allow ddprof version override to build a custom 'profiler-snapshot' dd-java-agent artifact #10265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow ddprof version override to build a custom 'profiler-snapshot' dd-java-agent artifact #10265
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085410
Total [baseline] (8.745 s) : 0, 8745478
Agent [candidate] (1.103 s) : 0, 1103273
Total [candidate] (8.79 s) : 0, 8790061
section iast
Agent [baseline] (1.22 s) : 0, 1220172
Total [baseline] (9.298 s) : 0, 9298011
Agent [candidate] (1.229 s) : 0, 1229195
Total [candidate] (9.309 s) : 0, 9309187
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (651.497 ms) : 0, 651497
BytebuddyAgent [candidate] (662.981 ms) : 0, 662981
GlobalTracer [baseline] (283.039 ms) : 0, 283039
GlobalTracer [candidate] (287.851 ms) : 0, 287851
AppSec [baseline] (32.612 ms) : 0, 32612
AppSec [candidate] (33.283 ms) : 0, 33283
Debugger [baseline] (68.133 ms) : 0, 68133
Debugger [candidate] (68.439 ms) : 0, 68439
Remote Config [baseline] (631.952 µs) : 0, 632
Remote Config [candidate] (618.49 µs) : 0, 618
Telemetry [baseline] (9.003 ms) : 0, 9003
Telemetry [candidate] (9.091 ms) : 0, 9091
Flare Poller [baseline] (3.739 ms) : 0, 3739
Flare Poller [candidate] (3.778 ms) : 0, 3778
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (789.988 ms) : 0, 789988
BytebuddyAgent [candidate] (794.93 ms) : 0, 794930
GlobalTracer [baseline] (255.104 ms) : 0, 255104
GlobalTracer [candidate] (257.331 ms) : 0, 257331
AppSec [baseline] (33.386 ms) : 0, 33386
AppSec [candidate] (35.781 ms) : 0, 35781
Debugger [baseline] (65.387 ms) : 0, 65387
Debugger [candidate] (64.289 ms) : 0, 64289
Remote Config [baseline] (619.325 µs) : 0, 619
Remote Config [candidate] (617.397 µs) : 0, 617
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.527 ms) : 0, 8527
Flare Poller [baseline] (3.598 ms) : 0, 3598
Flare Poller [candidate] (3.621 ms) : 0, 3621
IAST [baseline] (26.976 ms) : 0, 26976
IAST [candidate] (27.16 ms) : 0, 27160
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086118
Total [baseline] (10.763 s) : 0, 10763415
Agent [candidate] (1.087 s) : 0, 1086624
Total [candidate] (10.787 s) : 0, 10786885
section appsec
Agent [baseline] (1.28 s) : 0, 1279687
Total [baseline] (10.938 s) : 0, 10937934
Agent [candidate] (1.291 s) : 0, 1291473
Total [candidate] (11.121 s) : 0, 11120541
section iast
Agent [baseline] (1.237 s) : 0, 1237493
Total [baseline] (11.171 s) : 0, 11170906
Agent [candidate] (1.229 s) : 0, 1228575
Total [candidate] (11.198 s) : 0, 11197907
section profiling
Agent [baseline] (1.206 s) : 0, 1206136
Total [baseline] (10.215 s) : 0, 10214773
Agent [candidate] (1.215 s) : 0, 1214541
Total [candidate] (10.96 s) : 0, 10959885
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (651.722 ms) : 0, 651722
BytebuddyAgent [candidate] (651.601 ms) : 0, 651601
GlobalTracer [baseline] (282.709 ms) : 0, 282709
GlobalTracer [candidate] (283.527 ms) : 0, 283527
AppSec [baseline] (32.546 ms) : 0, 32546
AppSec [candidate] (32.65 ms) : 0, 32650
Debugger [baseline] (68.786 ms) : 0, 68786
Debugger [candidate] (68.558 ms) : 0, 68558
Remote Config [baseline] (640.814 µs) : 0, 641
Remote Config [candidate] (628.191 µs) : 0, 628
Telemetry [baseline] (9.08 ms) : 0, 9080
Telemetry [candidate] (8.936 ms) : 0, 8936
Flare Poller [baseline] (3.805 ms) : 0, 3805
Flare Poller [candidate] (3.749 ms) : 0, 3749
section appsec
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (698.672 ms) : 0, 698672
BytebuddyAgent [candidate] (705.457 ms) : 0, 705457
GlobalTracer [baseline] (260.954 ms) : 0, 260954
GlobalTracer [candidate] (264.601 ms) : 0, 264601
AppSec [baseline] (175.673 ms) : 0, 175673
AppSec [candidate] (176.542 ms) : 0, 176542
Debugger [baseline] (68.31 ms) : 0, 68310
Debugger [candidate] (67.86 ms) : 0, 67860
Remote Config [baseline] (775.159 µs) : 0, 775
Remote Config [candidate] (803.286 µs) : 0, 803
Telemetry [baseline] (9.566 ms) : 0, 9566
Telemetry [candidate] (9.477 ms) : 0, 9477
Flare Poller [baseline] (3.807 ms) : 0, 3807
Flare Poller [candidate] (3.89 ms) : 0, 3890
IAST [baseline] (24.889 ms) : 0, 24889
IAST [candidate] (25.526 ms) : 0, 25526
section iast
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (800.67 ms) : 0, 800670
BytebuddyAgent [candidate] (794.848 ms) : 0, 794848
GlobalTracer [baseline] (258.268 ms) : 0, 258268
GlobalTracer [candidate] (257.121 ms) : 0, 257121
AppSec [baseline] (32.951 ms) : 0, 32951
AppSec [candidate] (34.436 ms) : 0, 34436
Debugger [baseline] (68.458 ms) : 0, 68458
Debugger [candidate] (65.552 ms) : 0, 65552
Remote Config [baseline] (578.145 µs) : 0, 578
Remote Config [candidate] (595.228 µs) : 0, 595
Telemetry [baseline] (8.516 ms) : 0, 8516
Telemetry [candidate] (8.479 ms) : 0, 8479
Flare Poller [baseline] (3.625 ms) : 0, 3625
Flare Poller [candidate] (3.529 ms) : 0, 3529
IAST [baseline] (27.355 ms) : 0, 27355
IAST [candidate] (27.198 ms) : 0, 27198
section profiling
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (703.674 ms) : 0, 703674
BytebuddyAgent [candidate] (707.425 ms) : 0, 707425
GlobalTracer [baseline] (220.526 ms) : 0, 220526
GlobalTracer [candidate] (222.479 ms) : 0, 222479
AppSec [baseline] (32.198 ms) : 0, 32198
AppSec [candidate] (32.449 ms) : 0, 32449
Debugger [baseline] (68.627 ms) : 0, 68627
Debugger [candidate] (69.257 ms) : 0, 69257
Remote Config [baseline] (651.379 µs) : 0, 651
Remote Config [candidate] (653.907 µs) : 0, 654
Telemetry [baseline] (8.773 ms) : 0, 8773
Telemetry [candidate] (8.809 ms) : 0, 8809
Flare Poller [baseline] (3.612 ms) : 0, 3612
Flare Poller [candidate] (3.72 ms) : 0, 3720
ProfilingAgent [baseline] (96.915 ms) : 0, 96915
ProfilingAgent [candidate] (98.186 ms) : 0, 98186
Profiling [baseline] (97.521 ms) : 0, 97521
Profiling [candidate] (98.759 ms) : 0, 98759
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (18.018 ms) : 17832, 18204
. : milestone, 18018,
appsec (19.266 ms) : 19069, 19463
. : milestone, 19266,
code_origins (17.646 ms) : 17467, 17825
. : milestone, 17646,
iast (17.612 ms) : 17438, 17785
. : milestone, 17612,
profiling (18.582 ms) : 18395, 18768
. : milestone, 18582,
tracing (17.813 ms) : 17635, 17991
. : milestone, 17813,
section candidate
no_agent (19.152 ms) : 18955, 19349
. : milestone, 19152,
appsec (18.289 ms) : 18103, 18475
. : milestone, 18289,
code_origins (17.807 ms) : 17628, 17986
. : milestone, 17807,
iast (17.576 ms) : 17400, 17752
. : milestone, 17576,
profiling (18.364 ms) : 18181, 18548
. : milestone, 18364,
tracing (17.712 ms) : 17538, 17885
. : milestone, 17712,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.182 ms) : 1170, 1193
. : milestone, 1182,
iast (3.193 ms) : 3149, 3236
. : milestone, 3193,
iast_FULL (5.959 ms) : 5899, 6018
. : milestone, 5959,
iast_GLOBAL (3.388 ms) : 3340, 3436
. : milestone, 3388,
profiling (1.954 ms) : 1937, 1971
. : milestone, 1954,
tracing (1.849 ms) : 1831, 1866
. : milestone, 1849,
section candidate
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.134 ms) : 3097, 3170
. : milestone, 3134,
iast_FULL (5.766 ms) : 5709, 5823
. : milestone, 5766,
iast_GLOBAL (3.592 ms) : 3533, 3651
. : milestone, 3592,
profiling (2.002 ms) : 1985, 2019
. : milestone, 2002,
tracing (1.791 ms) : 1776, 1805
. : milestone, 1791,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.702 ms) : 3481, 3923
. : milestone, 3702,
iast (2.213 ms) : 2149, 2278
. : milestone, 2213,
iast_GLOBAL (2.257 ms) : 2192, 2322
. : milestone, 2257,
profiling (2.056 ms) : 2004, 2109
. : milestone, 2056,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.663 ms) : 3448, 3878
. : milestone, 3663,
iast (2.218 ms) : 2153, 2283
. : milestone, 2218,
iast_GLOBAL (2.26 ms) : 2195, 2325
. : milestone, 2260,
profiling (2.051 ms) : 1998, 2103
. : milestone, 2051,
tracing (2.041 ms) : 1990, 2092
. : milestone, 2041,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c5fa7cf076, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (15.521 s) : 15521000, 15521000
. : milestone, 15521000,
appsec (14.622 s) : 14622000, 14622000
. : milestone, 14622000,
iast (18.155 s) : 18155000, 18155000
. : milestone, 18155000,
iast_GLOBAL (17.911 s) : 17911000, 17911000
. : milestone, 17911000,
profiling (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
tracing (14.539 s) : 14539000, 14539000
. : milestone, 14539000,
section candidate
no_agent (15.598 s) : 15598000, 15598000
. : milestone, 15598000,
appsec (14.539 s) : 14539000, 14539000
. : milestone, 14539000,
iast (18.221 s) : 18221000, 18221000
. : milestone, 18221000,
iast_GLOBAL (17.932 s) : 17932000, 17932000
. : milestone, 17932000,
profiling (15.028 s) : 15028000, 15028000
. : milestone, 15028000,
tracing (14.496 s) : 14496000, 14496000
. : milestone, 14496000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
mcculls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment - the PR description mentions using -PddprofSnapshotVersion but the doc change suggests that -PddprofUseSnapshot is the flag to set.
bric3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concern here. But I can help move this forward.
…d-java-agent artifact
- Document new convention plugin approach - Update file list to include new files - Clarify that dependency override only affects relevant projects - Add example of plugin application in build files
Address PR review feedback from bric3: - Create dd-trace-java.profiling-ddprof-override convention plugin - Apply plugin only to projects that depend on ddprof (ddprof-lib) - Remove allprojects blocks from ddprof-override.gradle - Enhance TracerVersionPlugin to support version qualifiers - Use consistent property access (property() instead of ext) Benefits: - Only affects projects that explicitly apply the plugin - Follows Gradle best practices and project conventions - More maintainable and easier to understand - Clear separation of concerns The ddprof dependency override now happens via a convention plugin that projects can opt into, rather than affecting all projects globally.
8b98b1f to
c5fa7cf
Compare
What Does This Do
This PR adds the ability to 'override' the ddprof (Java Profiler) dependency with its current snapshot version.
This is done by adding
-PddprofUseSnapshotto the gradle task arguments.Motivation
We (the Java profiler team) are looking for faster dogfooding iteration which involves the complete integration of the profiler library to the tracer. This is the first, preparatory step in order to be able to do that regularly in the future.
Additional Notes
This change is not affecting anything else and it is completely optional to use.
The CI job is manually triggered only for now.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue