[APPS][Connections Part 3] Resolve same-module connection ID constants

[sdkennedy2]

Motivation

This builds on the inline connection ID extractor from #349. Inline string literals are safe, but backend code commonly assigns a connection ID to a same-file constant before passing it to action-catalog.

This PR adds the smallest useful same-module value resolver first so the follow-up object-map PR can be reviewed separately.

Changes

Adds same-module static value resolution for direct constant forms:

const CONNECTION_ID = '77c14b8b-27e1-4901-985d-8817908b9706';
request({ connectionId: CONNECTION_ID, inputs: {} });

The resolver tracks declarations by eslint-scope variable identity, preserving shadowing behavior from #349. It supports top-level same-file const strings, exported top-level consts, const-to-const chains, and static template literals without interpolation.

It intentionally rejects member expressions such as CONNECTIONS.HTTP, imported values, mutable bindings, function-local bindings, dynamic templates, calls, binary expressions, environment reads, and const cycles. Same-module object-map support is split into the next PR.

QA Instructions

Ran:

yarn workspace @dd/tests test:unit packages/plugins/apps/src/backend/ast-parsing/extract-connection-ids.test.ts --runInBand

Parent branch result: 46 tests passed.

Blast Radius

This affects Apps backend function discovery/upload/dev-server manifest generation for action-catalog connection allowlists. Runtime backend execution is unchanged. Unsupported known action-catalog connectionId forms fail closed instead of producing an incomplete allowlist.

Documentation

• PR Description Guidelines

[sdkennedy2]

• [APPS][Connections Part 6] Discover action calls in reachable modules #353
• [APPS][Connections Part 5] Move apps Vite behavior into getVitePlugin #357
• [APPS][Connections Part 4] Resolve same-module connection ID object values #354
• [APPS][Connections Part 3] Resolve same-module connection ID constants #351 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sdkennedy2]

We will expand upon this in a further PR (#354) to support object values such as CONNECTIONS.HTTP (

[sdkennedy2]

We plan on handling this in a future PR.

[sdkennedy2]

Its probably worth handling this in a followup PR.

[sdkennedy2]

@codex review
@cursor review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[michaeldfoley]

nit: if we don't want to cast as Expression, we could narrow findConnectionIdProperty's return type to Property & { value: Expression }

type ConnectionIdProperty = Property & { value: Expression };

function hasExpressionValue(property: Property): property is ConnectionIdProperty {
    const { value } = property;
    return (
        value.type !== 'ObjectPattern' &&
        value.type !== 'ArrayPattern' &&
        value.type !== 'RestElement' &&
        value.type !== 'AssignmentPattern'
    );
}

function findConnectionIdProperty(
    objectExpression: ObjectExpression,
    filePath: string,
): ConnectionIdProperty | undefined {
    let connectionIdProperty: ConnectionIdProperty | undefined;
    
    ...

            if (!hasExpressionValue(property)) {
                throw unsupportedActionCatalogCall(
                    filePath,
                    'destructuring pattern in connectionId value',
                );
            }
            connectionIdProperty = property;
        }
    }
    return connectionIdProperty;
}

[sdkennedy2]

Good call 👍. I'll make the change.