[chain-pr 6/12] Rewrite SessionManager with async start, deterministic sampling, and Promise-based init#4589
Draft
johnHackworth wants to merge 1 commit intov7--chain-5from
Draft
[chain-pr 6/12] Rewrite SessionManager with async start, deterministic sampling, and Promise-based init#4589johnHackworth wants to merge 1 commit intov7--chain-5from
johnHackworth wants to merge 1 commit intov7--chain-5from
Conversation
…c sampling, and Promise-based init
|
I have read the CLA Document and I hereby sign the CLA chain-pr[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New unified SessionManager built on the reactive store strategy, returning a Promise. Adds findTrackedSession with sample-rate gating, TRACKED_SESSION_MAX_AGE cap, expireDate cap at SESSION_TIME_OUT_DELAY, cross-tab adoption guard, telemetry init metric, and SessionRenewalEvent debug context. Adds collectAsyncCalls and createSessionManagerMock test helpers, plus trackingConsent.onGrantedOnce.
Refactoring rationale
Replaces the per-product (RUM/Logs) session managers with a single async SessionManager that returns a Promise and supports deterministic sampling, isReplayForced via session state, and a TRACKED_SESSION_MAX_AGE cap. The signature change from synchronous to Promise-based propagates through every consumer, which is why the entire startRum/startLogs/preStart pipeline must follow in the next group. Also extends TrackingConsent with onGrantedOnce to drive deferred initialization.
Draft — pending author review. Merge in order unless marked parallel.