[chain-pr 5/12] Rewrite session storage strategies as reactive setSessionState API#4588
Draft
johnHackworth wants to merge 1 commit intov7--chain-1from
Draft
[chain-pr 5/12] Rewrite session storage strategies as reactive setSessionState API#4588johnHackworth wants to merge 1 commit intov7--chain-1from
johnHackworth wants to merge 1 commit intov7--chain-1from
Conversation
|
I have read the CLA Document and I hereby sign the CLA chain-pr[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace persistSession/retrieveSession/expireSession with a single setSessionState(fn) + sessionObservable on each strategy. Adds CookieAccess abstraction with CookieStore API and document.cookie fallback. Migrates session key to _dd_s_v2 with legacy migration. Removes oldCookiesMigration and sessionStoreOperations.
Refactoring rationale
Fundamentally restructures the session storage layer from a synchronous persist/retrieve/expire trio into a single reactive setSessionState method backed by an observable. This unifies cookie, localStorage, and memory strategies under one contract, replaces the lock-based concurrency mechanism with Web Locks / promise chains, and bumps the storage key to _dd_s_v2 with legacy migration. It is the foundational change required before the new session manager can be built on top.
Draft — pending author review. Merge in order unless marked parallel.