Skip to content

[chain-pr 3/12] Replace BoundedBuffer with BufferedObservable and add onDrop#4586

Draft
johnHackworth wants to merge 1 commit intov7--chain-1from
v7--chain-3
Draft

[chain-pr 3/12] Replace BoundedBuffer with BufferedObservable and add onDrop#4586
johnHackworth wants to merge 1 commit intov7--chain-1from
v7--chain-3

Conversation

@johnHackworth
Copy link
Copy Markdown
Collaborator

This PR is part of a chain split from #0 v7 by chain-pr.

Changes

Remove the deprecated BoundedBuffer abstraction in favor of BufferedObservable, adding an onDrop callback for telemetry. Update bufferContextCalls and core index exports accordingly.

Refactoring rationale

Consolidates two overlapping buffering abstractions into one. BoundedBuffer is removed entirely and bufferContextCalls is reimplemented on top of BufferedObservable. The new onDrop callback enables tracking of dropped data via telemetry, which downstream consumers (preStartRum/preStartLogs) rely on.


Draft — pending author review. Merge in order unless marked parallel.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


chain-pr[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant