[Fix] missing leading slash on datasetname #123
+2,228
−1,634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #96 , which was noticed by multiple people now :D
I added a "regression" test using pytest, as this was the slimmest version I could think of/find. Unit-testing
Reader ::ReadInputFileis difficult due to theexit(10)at the end and the MPI constructions. An atomic unit-test using a proper framework would be for a newly introduced submethodnormalize_datasetname(), but I opted out of that for readability etc, as it seemed like an overkill, even though it being the "correct" and future-proof method.I also fixed a german problem on
run_test.sh, because the differentlocaleinterfered withbcin the script.Pre-Commit does not run currently, no luck with cleaning or something else.
Checklist:
CHANGELOG.md.