Tos gate base64 urls feature with TDD and new CI workflow#1269
Merged
Conversation
Member
artur-rs
commented
May 17, 2026
artur-rs
commented
- docs/javascripts/tos-gate.js - new revealGated() function, intentionally no rel="noreferrer - main.py - Added tos_gated_downloads(section_id, files, tos_url) macro; tos_checkbox kept for other uses - mkdocs.yml - Added javascripts/tos-gate.js to extra_javascript - overrides/main.html - New pins Referrer-Policy: strict-origin-when-cross-origin globally Signed-off-by: Artur Raglis <artur.raglis@3mdeb.com>
29 tests across four classes: - TestTosGatedDownloads (9) - macro unit tests: URL absent from HTML, base64/JSON roundtrip, group format encoding, checkbox attributes, prose_section_id, tos_url override - TestTosCheckbox (4) - legacy macro: element presence, section ID, URL defaults/override - TestTosGateJs (7) - JS file: function defined, noreferrer absent from link template but warning comment present, data-prose-group selector present, group branch present, prose hidden on uncheck - TestStaticFiles (9) - no plain dl.3mdeb.com links, correct macro usage in variants/ files, tos-gate.js in mkdocs.yml, permalink: true, referrer meta in overrides/main.html Signed-off-by: Artur Raglis <artur.raglis@3mdeb.com>
Signed-off-by: Artur Raglis <artur.raglis@3mdeb.com>
miczyg1
reviewed
May 18, 2026
Signed-off-by: Artur Raglis <artur.raglis@3mdeb.com>
artur-rs
force-pushed
the
tos-gate-base64-urls
branch
from
5b6b077 to
adfa93e
Compare
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
miczyg1
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.