Fixing Component Record formId and formName fields (Part 1) ...#437
Open
krishmaj wants to merge 2 commits into
Open
Fixing Component Record formId and formName fields (Part 1) ...#437krishmaj wants to merge 2 commits into
krishmaj wants to merge 2 commits into
Conversation
- component records have had 'formId' and 'formName' fields from the very start of the APA DB, whereas the same fields in action and workflow records have always been called 'typeFormId' and 'typeFormName' - absolutely no reason why these fields should be different depending on entity type ... they mean the same thing, and are assigned in the same way - literally the only difference is the field name - new administrator utility function to add 'typeFormId' and 'typeFormName' fields to all component records, with values copied from the existing 'formId' and 'formName' fields respectively - new components will now have the 'typeFormId' and 'typeFormName' fields added, in addition to the 'formId' and 'formName' ones - changed action and workflow records to pull the type form ID directly from the type form itself, instead of the submitted input ... keeps them consistent with (new) component records, and is more reliable in case the submitted input is malformed
Fixing Component Record formId and formName fields (Part 1) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes have been tested on Staging.
REMINDER - all 'batch' type component type forms will need to have 'subComponent_formId' changed to 'subComponent_typeFormId' in the interface.