fix(compiler): shrink merged live range after erasing coalesced COPYs#386
Merged
zoowii merged 3 commits intoDTVMStack:mainfrom Mar 6, 2026
Merged
fix(compiler): shrink merged live range after erasing coalesced COPYs#386zoowii merged 3 commits intoDTVMStack:mainfrom
zoowii merged 3 commits intoDTVMStack:mainfrom
Conversation
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes register coalescer correctness issues in the CGIR compiler pass by ensuring merged live intervals are shrunk appropriately after removing coalesced COPY instructions, addressing reported multipass JIT crashes (fix #160, fix #161).
Changes:
- Extend
JoinVals::eraseInstrsto propagate aShrinkMainRangeflag when erasing COPYs tied to the coalesced register pair. - Thread the new
ShrinkMainRangeout-param througheraseInstrscallers during virtual register joining. - Add two
spec_extraWAST regression tests covering the reported crash patterns.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/compiler/cgir/pass/register_coalescer.cpp |
Propagates a shrink signal from COPY erasure so the merged live range can be shrunk after coalescing. |
tests/wast/spec_extra/coalescer_memory_grow_local_tee.wast |
Regression test for the memory.grow + local.tee crash case. |
tests/wast/spec_extra/coalescer_if_local_tee.wast |
Regression test for the if + local.tee crash case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmgCr
force-pushed
the
cmgCr/fix_wasm_issuse
branch
from
2113baf to
399a2ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note