fix(evm): synchronize gas register with runtime gas state#377
Open
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
Open
fix(evm): synchronize gas register with runtime gas state#377abmcar wants to merge 1 commit intoDTVMStack:mainfrom
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
Conversation
Sync gas register around dynamic EXP charging and terminal runtime handlers so JIT register state does not drift from instance/message gas fields.\n\nGuard syncGasToMemoryFull() when current message is null to avoid invalid message gas writes after popMessage().\n\nThis removes gas-accounting mismatches observed with ZEN_ENABLE_EVM_GAS_REGISTER=ON in Cancun statetests.
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes the EVM “gas register” with the runtime’s in-memory gas fields to prevent gas-accounting drift when running the multipass JIT with ZEN_ENABLE_EVM_GAS_REGISTER enabled (notably seen in Cancun state tests).
Changes:
- Guard
syncGasToMemoryFull()so it skips writingmessage->gaswhen there is no current message (e.g., afterpopMessage()). - Sync/reload gas around EXP dynamic gas charging to keep the JIT register consistent with
instance->Gas. - Reload gas after terminal runtime handlers (RETURN/REVERT/INVALID/UNDEFINED/SELFDESTRUCT) so later full-syncs don’t clobber runtime-updated gas.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 20%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 20%)
Summary: 194 benchmarks, 0 regressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync gas register around dynamic EXP charging and terminal runtime handlers so JIT register state does not drift from instance/message gas fields.\n\nGuard syncGasToMemoryFull() when current message is null to avoid invalid message gas writes after popMessage().\n\nThis removes gas-accounting mismatches observed with ZEN_ENABLE_EVM_GAS_REGISTER=ON in Cancun statetests.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note