Update notification case: missing nemesis records#1537
Open
SilasD wants to merge 2 commits intoDFHack:masterfrom
Open
Update notification case: missing nemesis records#1537SilasD wants to merge 2 commits intoDFHack:masterfrom
SilasD wants to merge 2 commits intoDFHack:masterfrom
Conversation
Changes: changed the color of the overlay text "missing # nemesis records": * light red when there are affected units on the map. * yellow otherwise. changed the color of the popup window text "permanently disappear": * red when there are affected units on the map. * white otherwise. added notice (in yellow) when there are no affected units on the map. changed the text "active units" to "units on the map" in three places. don't indent unit names; showing them in light red is enough. if the unit name is length is too long, show it without the english name. (internal) implemented caching of tests. (internal) moved all the cache logic into an object. (internal) note: has some debugging-data printing enabled.
tested in adventurer mode -- both sub-cases work. (internal) fixed bug in onStateChange callback. (internal) cache unit ids, NOT units. (oopsie!) (don't worry, caching units never got out into the wild.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #1529
Discord discussion:
1/11/2026 through roughly 1/13/26.
Especially note Quietust's question about the detection method.
Depending on how Bay12 repairs missing nemesis records, the current simplistic detection method may not be valid. (Basically, will they put new ids in the new records.)
I have worked on an alternate detection method based on walking all histfigs and all nemesis records, but have not tested it or tried to put it in to this PR. My gut feeling is that such a test would be slow.
Changes: