Added initial version and build to About view. Cleaned up SpiderOak l…#87
Added initial version and build to About view. Cleaned up SpiderOak l…#87Bennyoak wants to merge 1 commit intoCrypton:b-3from
Conversation
…ogo on about view
|
The only thing I would add (havent built it yet) is a comment about app.kloak_version and app.build are properties in the un-checked-in www/js/configuration.js Also, change the kloak_version property to "public_version" |
|
Yeah that should be a README note in www/js/ maybe? |
|
@Bennyoak yeah, adding that to the README is a great idea |
There was a problem hiding this comment.
we should change app.kloak_version to app.app_version as well as add a section to the README about the existence of these required properties that should be in configuration.js
perhaps the best thing to do is add a section for "Configuration" in the readme where you display a sample configuration.js that has comments for each line?
There was a problem hiding this comment.
Other than that, I can merge this PR
2 participants
…ogo on about view
Same thing as PR #82 but not configuration.js