This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Open
Conversation
…s, with some hardcoded data
…erform the actual subscription
…name field This will allow for more accurate use of the name parts, ie. addressing an email by the user's first name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Mailchimp integration to the existing Entry creation process.
Some of my thought processes, considerations not coded here and tradeoffs are detailed in
doc/considerations.md.I don't have any tests hitting the Mailchimp API directly - I don't think this is a great practice, but am willing to discuss the pros and cons and possibly add a few more tests to do so!