Conversation
- Add optional --source flag to validate command for file existence checking - Implement cycle detection to identify control loops in workflows - Add ZMQ port conflict detection and validation - Warn about reserved ports (< 1024) and invalid port ranges - Expand test coverage with 6 new comprehensive test cases - Update CLI documentation with new validation features This improves the user experience by catching common configuration errors before workflow execution, reducing runtime failures.
- Add explicit validation for port 0 (invalid) - Enforce directory-only input for --source option - Use warnings parameter in _check_source_files for clarity - Add test coverage for port 0 and port > 65535 edge cases - Reorder port validation to check range before conflicts
The inspect command had no tests, which left a gap in our test coverage. Added 4 new tests covering: - Basic workflow inspection - JSON output format - Missing file error handling - Detection of missing source files All tests pass.
…rfile optimize Dockerfile.v by clearing apt cache
…dation Feature/enhanced workflow validation
Add concore editor to CLI
…HM_SIZE constant (#514) The C++ shared memory implementation in concore.hpp and concoredocker.hpp allocated a fixed 256-byte buffer for inter-node data exchange and silently truncated any payload exceeding 255 characters. Changes: - Add static constexpr SHM_SIZE = 4096 in both concore.hpp and concoredocker.hpp - Replace all hardcoded 256 in shmget(), strnlen(), and strncpy() with SHM_SIZE - Add overflow detection: stderr error message when payload exceeds SHM_SIZE - Add explicit null termination after strncpy() to prevent read overruns - Buffer now supports ~200+ double values (up from ~25) Fixes #514
…verification Address Copilot review feedback: - Add sharedData_create != nullptr check before strncpy/null-termination in all write_SM() overloads to prevent null pointer dereference when shmat() fails in createSharedMemory() - Add shmctl(IPC_STAT) verification in createSharedMemory() to detect stale segments smaller than SHM_SIZE (shmget won't resize existing segments); removes and recreates the segment when too small - Add early return in concore.hpp createSharedMemory() on shmget failure (was missing, unlike concoredocker.hpp which already had it)
Rename CLI command run → build to reflect actual behaviour
ci: add java phase-2 conformance coverage
…on-514 Fix: Replace hardcoded 256-byte shared memory buffer with 4096-byte
add java end-to-end study example
cardiac_pm.py in humanc/ and tools/ (symlinked by linktest/) imported pulsatile_model_functions and healthy_params directly, but these modules only exist inside the cardiac_pm.dir/ subdirectories. Add sys.path manipulation to insert the cardiac_pm.dir/ directory into the import path so the modules are found both during development and after deployment via mkconcore.py.
- Guard sys.path.insert with a duplicate check to avoid accumulating entries on repeated imports/reloads (Copilot review suggestion). - Replace bare except with except (ValueError, SyntaxError) in sample/PZ/pm.py and sample/src/pm.py to fix ruff E722.
fix: resolve broken imports in cardiac_pm.py (#290)
…runtime-cases extend conformance matrix with read_file cases
Attempt to fix the workload integration failure.
Member
Author
|
/gemini-review |
Member
Author
|
Ok, I thought we sorted out the gemini bot for this repository. Did not work? |
Docs: Add CONFIG.md documenting config files, env vars, and precedence
cli: add JSON output for concore validate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.