Strip malformed @comment{...} blocks from cdl.bib (fixes bibtex breakage)#77
Open
jeremymanning wants to merge 2 commits intomasterfrom
Open
Strip malformed @comment{...} blocks from cdl.bib (fixes bibtex breakage)#77jeremymanning wants to merge 2 commits intomasterfrom
jeremymanning wants to merge 2 commits intomasterfrom
Conversation
All three entries individually web-verified and formatted to pass
bibcheck verify. These ground the "what is a volunteer mesh"
section of the companion whitepaper to the Kiewit Provost
Leadership Fellows application.
- AndeEtal02: SETI@home (Anderson, Cobb, Korpela, Lebofsky,
Werthimer), Communications of the ACM 45(11):56-61,
DOI 10.1145/581571.581573. The canonical volunteer-compute
precedent; verified via ACM DL and author-hosted PDF at
setiathome.berkeley.edu/sah_papers/cacm.php.
- Ande04: BOINC (David P. Anderson, single author),
Proceedings of the 5th IEEE/ACM International Workshop on
Grid Computing, pp. 4-10, DOI 10.1109/GRID.2004.14. The
software platform that underlies SETI@home / Folding@home /
many later volunteer-computing projects. Journal string
shortened to "IEEE International Workshop" (dropping the
"/ACM" join) to match CDL conventions on brace-protected
caps tokens.
- VoelEtal23: Folding@home (Voelz, Pande, Bowman),
Biophysical Journal 122(14):2852-2863,
DOI 10.1016/j.bpj.2023.03.028. The 20-year retrospective
and the most-citable peer-reviewed reference for the
Folding@home tradition.
Integrity check: python bibcheck.py verify cdl.bib -> looks good!
(6206 entries, up from 6203).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The PR #74 / #75 / #76 commits inadvertently introduced @comment{...} blocks into cdl.bib via bibtexparser's serialization. bibtex's parser chokes on the embedded URLs and commas inside those blocks (the \"Folding@home, treating it\" pattern is the most direct trigger), causing exit-code-2 failures for any downstream document that runs bibtex against the master cdl.bib. The fix: strip @comment{...} entirely. The audit-trail content these blocks carried is preserved in the original PR descriptions and in each submodule commit message, which is the appropriate place for that history. cdl.bib is now machine-clean again. Verification: python bibcheck.py verify cdl.bib -> looks good! (6206 entries) bibtex (against a downstream document) -> exit 0, no errors Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #74, #75, and #76 inadvertently introduced `@comment{...}` blocks into `cdl.bib` via bibtexparser's serialization. bibtex's parser chokes on the embedded URLs and commas inside those blocks (the "Folding@home, treating it" pattern is the most direct trigger), causing exit-code-2 failures for any downstream document that runs bibtex against master.
This PR strips all `@comment{...}` blocks from `cdl.bib` so it parses cleanly again.
What changed
Why @comment isn't the right tool here
bibtex parses `@comment{...}` looking for balanced braces, but it does so character-by-character without robustly handling commas, embedded `@` characters (e.g. `Folding@home`), or URL-style `{...}` nesting. A line like:
```
@comment{% VoelEtal23: 20-year retrospective on Folding@home, treating it
% as a canonical volunteer-compute precedent...
```
makes bibtex skip the rest of the entry, which then breaks any document that cites entries appearing later in the file.
The audit-trail content those comments carried is preserved in the merged PR descriptions and the submodule commit messages, which is the correct place for that history.
Verification
```
python bibcheck.py verify cdl.bib -> looks good! (6206 entries)
bibtex (against a downstream document) -> exit 0, no errors
```
Test plan
🤖 Generated with Claude Code