Fixed E-Board director role checking #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add _director * fixed broken directorship function * fixed unused imports * fixed unused imports again
BigSpaceships
approved these changes
Jan 29, 2026
Contributor
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
LGTM, not an rtp or financials or evals but it won't be a regression either way and I cant impersonate and @mob did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The function to check if you were a certain E-Board member was not working. This fixes it. This also removes an unused legacy function.
Why
E-Board members weren't getting the proper access to Conditional.
Test Plan
ran locally tested with users.
Env Vars
no
Checklist