Mark Golang hosting package as obsolete#1323
Open
DavidGarton8 wants to merge 1 commit into
Open
Conversation
The `CommunityToolkit.Aspire.Hosting.Golang` package and its members have been marked as obsolete in favor of the newer `Aspire.Hosting.Go` package. Added warnings and updated documentation to guide users toward migrating to the replacement package. No functional changes were made, and the old package remains available for compatibility.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1323Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1323" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1315
Marks the
CommunityToolkit.Aspire.Hosting.Golangpackage as obsolete in favor ofAspire.Hosting.Go.This change:
Obsoleteattributes to the legacy extension type, public extension methods, and legacy resource typesAspire.Hosting.GoAspire.Hosting.GoCS0618warnings in test and example projects that intentionally continue using the legacy APIsNo functional behavior was changed.
PR Checklist
Other information
This PR intentionally does not introduce a replacement implementation in this package. It only marks the existing package surface as obsolete and updates documentation to direct users to
Aspire.Hosting.Go.This PR should be merged when
13.4.0is released, so the obsoletion guidance can direct users toAspire.Hosting.Goonce that package is publicly available.