Swap deprecated flagd package#1272
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
…re.Providers.Flagd Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1272Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1272" |
There was a problem hiding this comment.
Pull request overview
Updates the Flagd-related sample and test projects to use the non-deprecated OpenFeature.Providers.Flagd NuGet package (and namespace) instead of OpenFeature.Contrib.Providers.Flagd, keeping dependencies consistent across the repo.
Changes:
- Replaces the deprecated Flagd provider package with
OpenFeature.Providers.Flagdand bumps the centrally-managed version to0.6.0. - Updates affected
.csprojpackage references to the new package ID. - Updates
usingdirectives in the Flagd AppHost sample and Flagd tests to the new namespace.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Directory.Packages.props |
Swaps central package version entry to OpenFeature.Providers.Flagd 0.6.0. |
tests/CommunityToolkit.Aspire.Hosting.Flagd.Tests/CommunityToolkit.Aspire.Hosting.Flagd.Tests.csproj |
Updates test project package reference to the new Flagd provider package ID. |
tests/CommunityToolkit.Aspire.Hosting.Flagd.Tests/AppHostTests.cs |
Updates Flagd provider namespace import for tests. |
examples/flagd/CommunityToolkit.Aspire.Hosting.Flagd.AppHost/Program.cs |
Updates Flagd provider namespace import in the sample AppHost. |
examples/flagd/CommunityToolkit.Aspire.Hosting.Flagd.AppHost/CommunityToolkit.Aspire.Hosting.Flagd.AppHost.csproj |
Updates sample AppHost package reference to the new Flagd provider package ID. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@aaronpowell can you please have a look into this PR? I don’t know why it got closed |
|
waiting for #1288 to be merged so we can have a clean build |
|
waiting for #1261 to solve ci issues |
|
@aaronpowell tests are failing but does not seem related to the actual pr changes. are there issues with the ci? |
d35d397
into
CommunityToolkit:main
Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com
This pull request updates the codebase to use the new
OpenFeature.Providers.Flagdpackage instead of the deprecatedOpenFeature.Contrib.Providers.Flagdpackage. The changes ensure that all references, package dependencies, and using statements are consistent with the new package version.Dependency and Reference Updates:
Directory.Packages.propsto useOpenFeature.Providers.Flagdversion 0.6.0 instead ofOpenFeature.Contrib.Providers.Flagd..csproj) to referenceOpenFeature.Providers.Flagdinstead ofOpenFeature.Contrib.Providers.Flagd. [1] [2]Code Changes:
usingstatements in code and test files to referenceOpenFeature.Providers.Flagdinstead ofOpenFeature.Contrib.Providers.Flagd. [1] [2]PR Checklist
Other information
This only affects unit tests. Integration is not affected.