Open
Conversation
joachimvh
reviewed
Oct 2, 2023
Member
joachimvh
left a comment
joachimvh
left a comment
There was a problem hiding this comment.
I personally have no experience with the builtin fetch in node. There's also an issue in the authn library blocking me from updating the oidc-provider library in CSS, which is necessary when updating to node 18, but hoping to get that fixed before the next major release.
I did see some issues passing by about the fetch of which I don't know how big of an impact this could be. For example comunica/comunica#1252. So probably want to run some tests with CSS to see if there is an impact there.
Comment on lines
+7
to
+9
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| global.fetch = jest.fn(); |
Member
There was a problem hiding this comment.
Might want to use jest.spyOn so you don't need to @ts-ignore. E.g., https://stackoverflow.com/questions/73597037/how-to-test-mock-a-fetch-api-in-a-react-component-using-jest .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joachimvh this PR removes the
node-fetchdependency because I believe node 18 fetch is enough (and node 16 is not supported anymore).I'm planning to get that in and publish version
3.0.0of the library with minimum node 18 support including @woutermont's contribution to expose caching.What do you think?