Glasgow | 26-ITP-May | Niangh Ciang | Sprint 1 | Form Controls#1272
Open
Niangh-Ciang wants to merge 3 commits into
Open
Glasgow | 26-ITP-May | Niangh Ciang | Sprint 1 | Form Controls#1272Niangh-Ciang wants to merge 3 commits into
Niangh-Ciang wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Niangh-Ciang
added
Needs Review
Luro91
reviewed
May 15, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
The code works well. Please take a look at the format of the code itself
| required | ||
| minlength="2" | ||
| pattern=".*\S.*" | ||
| placeholder="Jane Doe" |
There was a problem hiding this comment.
The indentation is a bit off. How can you ensure consistent formatting in your code?
Comment on lines
+2
to
+3
| background-image: url("image.jpg"); | ||
| background-size: cover; |
There was a problem hiding this comment.
The indentation is a bit off. How can you ensure consistent formatting in your code?
Luro91
added
Reviewed
Niangh-Ciang
added
the
Needs Review
|
Thanks for fixing the indentation. I was referring to Prettier which you can use to automatically format your code so that you do not have to think about it |
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I added the full form structure, including name and email inputs, colour radio buttons, a size dropdown, a background image, and updated CSS styling to improve layout and readability.