London | 26-ITP-May | Remi M. B. | Module-Onboarding Sprint 1 | Form Controls#1258
London | 26-ITP-May | Remi M. B. | Module-Onboarding Sprint 1 | Form Controls#1258remimarcelle wants to merge 10 commits into
Conversation
…ng requirement for fingers, improves accessibility
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It seems I accidently committed code from the wireframe task in this pull request? Idk how |
Luro91
left a comment
There was a problem hiding this comment.
Looks good. I have a comment about the code formatting
Luro91
left a comment
There was a problem hiding this comment.
Well done.
Thanks for formatting the code. (FYI I also answered your comment here: #1258 (comment))
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Module-Onboarding Sprint 1) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |

Self checklist
Changelist
Built a form to collect t-shirt orders using HTML only. It asks for the
customer's full name, email address, t-shirt colour (radio buttons) and
size (dropdown). Wrapped inputs and radio button labels in p tags to add
spacing between touch targets, bringing the Lighthouse accessibility
score from 92 to 100.
Questions
Do I have to screenshot that I used devtools to refactor before I changed the code in vscode?