Sheffield | 26-Jan-ITP | Karim Mhamdi | Sprint 2 | Form Controls #1102
Conversation
…ccessibility improvements
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KKtech06
added
the
Needs Review
There was a problem hiding this comment.
-
Branch is not clean -- a branch for the Form Controls exercise should not contain changed files in the Wireframe folder. Can you revert the changes made in the Wireframe folder?
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
I spotted some minor inconsistent use of letter case and wordings on the form. May I suggest sharing your code to an AI tool and ask it to review your code in terms of semantic, accessibility, typo, and consistency?
It can often help us catch errors, improve consistency, and reinforce best practices. -
It is uncommon to have a submit button in the middle of the form. Can you move it to the bottom of the form?
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form> | ||
| <table> |
There was a problem hiding this comment.
I don't think it is a good practice to use table to layout form elements.
For this exercise, just use <div> or <br> to create enough space to pass the Lighthouse accessibility check.
| <td><input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| minlength="2" | ||
| required ></td> |
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
cjyuan
added
Reviewed
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Learners, PR Template
Self checklist
Changelist:
I created a form control with inputs where you can write your info such as your name and email and have also used labels to created section of colours to pick and sizes. and have ran a inspection test with lighthouse and got a score of 100
Questions
N/A