Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2 | Form Controls

[MehrozMunir]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I have created a form using html to get inputs from the user including their name, email, color and size of the shirt they want. And a submit button.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	b1566e4
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/69820b1bc5283500080de710
😎 Deploy Preview	https://deploy-preview-1030--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[jenny-alexander]

Hi @MehrozMunir, your form controls exercise is done very well. The form validation works nicely and you have used semantic HTML. I think the use of <p> is a little bit excessive but you most likely did this for styling purposes. Since CSS can't be used for styling, I'll let this pass. 🙂

I left a few comments in the code. Please have a look.

[MehrozMunir]

Hi @jenny-alexander
Thank you for reviewing my code and providing valuable feedback.

[jenny-alexander]

Hi @MehrozMunir - I changed the PR back to 'reviewed' since you have not addressed my comments on code changes. The work isn't complete until the reviewer changes the label to 'Complete'!
Here is the CYF guide (check out the Completing a PR section): https://programming.codeyourfuture.io/guides/reviewing/trainee-pr-guide/#addressing-reviewer-feedback

[MehrozMunir]

Hi @jenny-alexander , sorry for the confusion earlier. I misunderstood your comments and thought they were general instructions for future work, so I didn’t make the changes at the time. I also overlooked the rule that the reviewer should change the label from reviewed to complete, not me; apologies for that.

I’ve now committed the changes you mentioned in the code comments. Could you please take another look when you have a moment? Thank you!

[jenny-alexander]

Can you research and see if doctype should be uppercase or lowercase?

[MehrozMunir]

Yeah I see that now. Though it does not make any difference in the output as the HTML5 is case insensitive to the tag Doctype but the standard is to use with the uppercase "D". Thank you. I have corrected my code with capital D now.

[jenny-alexander]

Perhaps something other than <h2> would be a better choice for the footer? By using <h2> you are announcing a major section header within your footer.

[MehrozMunir]

Yeah that's right. I have changed it from heading to putting it inside the <small> tag.

[jenny-alexander]

@MehrozMunir I apologize, I forgot to hit the 'submit' button with my 2 feedback comments. Would you be able to have a quick look at what I wrote?

[MehrozMunir]

Hi @jenny-alexander Thank you for highlighting the issues in your comments. I have tried to solve them and committed my changes. Take a look please.

[jenny-alexander]

Nice job 👏 @MehrozMunir