Skip to content

🍪 feat: Configurable Secure Cookie Behavior#25

Merged
danny-avila merged 2 commits intoClickHouse:mainfrom
XHyperDEVX:add/configurable-secure-cookie-env
Apr 13, 2026
Merged

🍪 feat: Configurable Secure Cookie Behavior#25
danny-avila merged 2 commits intoClickHouse:mainfrom
XHyperDEVX:add/configurable-secure-cookie-env

Conversation

@XHyperDEVX
Copy link
Copy Markdown
Contributor

@XHyperDEVX XHyperDEVX commented Apr 13, 2026

Summary

This pull request introduces a configurable environment variable, SESSION_COOKIE_SECURE environment .env.example to allow explicit control over whether the session cookie is sent only over HTTPS. By default, this is true in production and false otherwise.

  • Updated src/server/session.ts to use the new SESSION_COOKIE_SECURE variable for the session cookie's secure attribute, instead of relying solely on the NODE_ENV value. [1] [2]

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

  • Confirm toggling of new environment variable behaves as expected in all possible combinations of configurations

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • Local unit tests pass with my changes

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 13, 2026

CLA assistant check
All committers have signed the CLA.

@dustinhealy dustinhealy changed the title add/configurable secure cookie env 🍪 feat: Configurable Secure Cookie Behavior Apr 13, 2026
@danny-avila danny-avila merged commit f4e299b into ClickHouse:main Apr 13, 2026
4 checks passed
@XHyperDEVX XHyperDEVX deleted the add/configurable-secure-cookie-env branch April 13, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants