Skip to content

♿ chore: Bump Click UI to v0.2.0-rc.4, Fix Dialog A11y Warnings#21

Merged
dustinhealy merged 2 commits intomainfrom
chore/update-package-click-ui-to-v0.2.0-rc.3
Apr 10, 2026
Merged

♿ chore: Bump Click UI to v0.2.0-rc.4, Fix Dialog A11y Warnings#21
dustinhealy merged 2 commits intomainfrom
chore/update-package-click-ui-to-v0.2.0-rc.3

Conversation

@punkbit
Copy link
Copy Markdown
Contributor

@punkbit punkbit commented Apr 10, 2026

Summary

Bumps @clickhouse/click-ui from 0.0.252-test.7 to 0.2.0-rc.4 and resolves all Radix Dialog console warnings.

Click UI changes (rc.2–rc.4):

  • Dialog.Title now uses RadixDialog.Title primitive — suppresses DialogContent requires a DialogTitle warning
  • Hidden RadixDialog.Description rendered when no description prop is provided — suppresses Missing Description warning

Admin panel changes:

  • Deduplicate @radix-ui/react-dialog via Vite resolve.dedupe and overrides — cmdk bundled its own copy with a separate Radix context, preventing our fixes from working
  • Add hidden DialogTitle + DialogDescription to all Command.Dialog usages (CommandMenu, ScopeSelector) since cmdk doesn't render these Radix primitives internally

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • All dialogs render correctly (edit role, edit group, create role, create group, edit capabilities, settings, confirm save, import YAML, profile value, delete profile value, profile indicator, user detail)
  • Command menu (Cmd+K) opens without console warnings
  • Scope selector (base config switcher) opens without console warnings
  • No DialogContent requires a DialogTitle warnings in console
  • No Missing Description warnings in console
  • No visual regressions — dialogs look identical to before

Closes #13

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 10, 2026

CLA assistant check
All committers have signed the CLA.

- Bump @clickhouse/click-ui to 0.2.0-rc.4 (includes hidden
  RadixDialog.Description fix for the missing Description warning)
- Add @radix-ui/react-dialog to Vite dedupe to resolve duplicate
  Radix context between cmdk and click-ui
- Add override to pin @radix-ui/react-dialog to 1.1.15
- Add hidden DialogTitle + DialogDescription to all Command.Dialog
  usages (CommandMenu, ScopeSelector) to suppress cmdk's Radix
  accessibility warnings

Closes #13
@dustinhealy dustinhealy changed the title chore: 🤖 update click ui v0.2.0-rc.3 ♿ chore: Bump Click UI to v0.2.0-rc.4, Fix Dialog A11y Warnings Apr 10, 2026
@dustinhealy dustinhealy merged commit 6ed12e2 into main Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] DialogContent requires a DialogTitle for the component error on Console

4 participants