chore(monorepo): 🤖 Independent Package Publisher (NPM)#953
chore(monorepo): 🤖 Independent Package Publisher (NPM)#953punkbit wants to merge 17 commits intochore/monorepo-changeset-root-setupfrom
Conversation
|
This has been covered in #947. Please ignore!
This has been covered in #947. Please ignore! |
|
🚨 Must Fix
Anything related with parsing the changelog + AWK should be ignored because this has been covered in #947. Please ignore! |
There was a problem hiding this comment.
Pull request overview
Adds a manually triggered GitHub Actions workflow to publish non-Click UI packages from the monorepo to npm using OIDC trusted publishing, and updates release/security documentation to reflect the new flow.
Changes:
- Added
monorepo-package-release.ymlworkflow to build, validate, and publish a selected./packages/*workspace with optional dry-run mode. - Documented monorepo package release responsibilities (manual changeset/versioning) and npm trusted publisher setup requirements.
- Updated README release section to point to both Click UI and monorepo package release docs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/click-ui/docs/package-release.md |
Adds documentation for the new monorepo package release workflow and npm trusted publishing setup. |
README.md |
Links release docs for Click UI vs supporting monorepo packages. |
.llm/SECURITY.md |
Adds guidance about avoiding workflow_dispatch input interpolation in run: blocks to prevent shell injection. |
.github/workflows/monorepo-package-release.yml |
Introduces a manual, package-selectable npm publisher workflow using OIDC/provenance with optional dry-run, GitHub release, and Slack notification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
04de869 to
8899067
Compare
aaa552a to
c32e923
Compare
|
Claude finished @punkbit's task in 1m 51s —— View job PR ReviewNice clean-up across these commits — the two blockers from the previous review are resolved. Here's the updated state: ✅ Previously flagged blockers — now resolved
💡 Suggestions (non-blocking)
✅ No issues with:
|
|
Claude finished @punkbit's task in 1m 23s —— View job PR Review
This is a well-structured workflow addition. All previously flagged blockers are resolved. Here's the current state: ✅ Previously resolved
💡 Suggestions (non-blocking — all previously noted)
✅ No issues with:
|
507b3f3 to
a69cc75
Compare
…ent branch now deprecated)
…e-publisher.yml → monorepo-package-release.yml
…m_branch) now flow through env: blocks
…aining why direct interpolation of string inputs into run: blocks is dangerous, a before/after code example, and a note that choice and boolean inputs are safe to interpolate
…ackage_name and version to env: extract changelog (lines 203-206): moved version, package_path, and changelog_file to env:
… with node-version: '23.x' already ships npm 10.x, which has full --provenance support — no upgrade needed
…ge.json instead of the root package.json
61cd422 to
57ce616
Compare
|
Claude finished @punkbit's task in 1m 6s —— View job PR Review
This is a clean, well-structured workflow addition. All blockers from previous review rounds are resolved. Here's the current state: ✅ Previously resolved
💡 Suggestions (non-blocking — previously noted, included for completeness)
✅ No issues with:
|
📚 Storybook Preview Deployed✅ Preview URL: https://click-7o5so5rqb-clickhouse.vercel.app Built from commit: |
Why?
The existing release workflow's hardcoded for
@clickhouse/click-ui. Supporting packages likedesign-tokensthat live under./packages/*need a way to publish independently without coupling to the click-ui release cycle (e.g. test/release-candidate -> stable -> latest) and related side-effects (e.g. branch namechore/v<Major.minor.patch>.💡 In the next iteration, this workflow can have a similar automation to click-ui
How?
Preview?
N/A