-
Notifications
You must be signed in to change notification settings - Fork 69
Improve LivingSetAttackEvent #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kappa-maintainer
merged 23 commits into
CleanroomMC:main
from
Ecdcaeb:ench-attacktargetevent
Feb 13, 2026
Merged
Improve LivingSetAttackEvent #29
kappa-maintainer
merged 23 commits into
CleanroomMC:main
from
Ecdcaeb:ench-attacktargetevent
Feb 13, 2026
+59
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rongmario
requested changes
Jan 30, 2026
Member
Rongmario
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to new cleanroom + refresh patches + small changes and it can be pulled in.
src/main/java/net/minecraftforge/event/entity/living/LivingSetAttackTargetEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minecraftforge/event/entity/living/LivingSetAttackTargetEvent.java
Show resolved
Hide resolved
src/main/java/net/minecraftforge/event/entity/living/LivingSetAttackTargetEvent.java
Outdated
Show resolved
Hide resolved
Rongmario
approved these changes
Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable change the target in the event.
the existed hook is
@DeprecatedWhy I edit this event
The old event do not imple the redirection of target. When our mod involves it we have to use reflection or AT.
Why the old hook remained
I noticed that