Skip to content

Upgrade Biome to 2.4.2#163

Draft
nnoce14 wants to merge 1 commit intomainfrom
nnoce14/issue162
Draft

Upgrade Biome to 2.4.2#163
nnoce14 wants to merge 1 commit intomainfrom
nnoce14/issue162

Conversation

@nnoce14
Copy link
Member

@nnoce14 nnoce14 commented Feb 23, 2026

Fixes #162

Summary by Sourcery

Upgrade linting tooling and apply required code style updates across the UI and mongoose seedwork packages.

Enhancements:

  • Refine UI components to use safer globals, cleaner JSX (remove unnecessary fragments), and null returns instead of empty fragments.
  • Simplify dropdown menu item initialization and iteration patterns, and tidy mongoose array helper by removing obsolete commented code and clarifying iteration bodies.

Build:

  • Upgrade @biomejs/biome to version 2.4.2 and adjust package overrides, including adding a minimatch override.
  • Refresh Biome configuration and pnpm lockfile in line with the tooling upgrade.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 23, 2026

Reviewer's Guide

Upgrades Biome from 2.0.0 to 2.4.2 and applies the new linter/formatter recommendations across UI components and a Mongoose helper, plus adds a dependency override for minimatch.

File-Level Changes

Change Details Files
Align UI components with updated lint/format rules and safer globals usage.
  • Use globalThis.location instead of window.location for redirect in the Header login handler
  • Simplify JSX in Header by removing unnecessary React fragments around a single root div
  • Use null instead of an empty fragment when conditionally rendering nothing in CommunityDetail helper functions
  • Fix indentation/formatting in CommunityDetail to satisfy formatter rules
apps/ui-community/src/components/layouts/root/components/header.tsx
apps/ui-community/src/components/layouts/admin/components/community-detail.tsx
Apply Biome-driven style and safety updates to the communities dropdown logic.
  • Use nullish coalescing assignment (??=) when initializing entries in itemsMap for community members
  • Wrap forEach callback body in braces to prevent implicit returns and match style rules
apps/ui-community/src/components/ui/organisms/dropdown-menu/communities-dropdown.tsx
Tighten Mongoose array helper implementation to satisfy updated lint rules.
  • Wrap docArray.pull calls inside forEach with braces for clearer side-effectful iteration
  • Remove obsolete commented-out code for initializing docArray
packages/cellix/mongoose-seedwork/src/mongoose-seedwork/mongoose-prop-array.ts
Upgrade Biome and dependency overrides to support the new tooling version.
  • Bump @biomejs/biome from 2.0.0 to ^2.4.2 in devDependencies
  • Add an overrides entry for minimatch version 10.2.1 alongside existing overrides
  • Update biome.json configuration and pnpm-lock.yaml to reflect the tooling upgrade
package.json
biome.json
pnpm-lock.yaml

Assessment against linked issues

Issue Objective Addressed Explanation
#162 Upgrade the @biomejs/biome devDependency in the root package.json to version 2.4.2.
#162 Ensure linting continues to work with Biome 2.4.2 (including any required code or configuration changes to satisfy the linter).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Biome to 2.4.2

1 participant