Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rkalis
requested changes
Mar 3, 2026
Member
rkalis
left a comment
rkalis
left a comment
There was a problem hiding this comment.
There's some things we should fix.
| ]; | ||
|
|
||
| // Generate bytes1-bytes32 | ||
| for (let i = 1; i <= 32; i++) { |
Member
There was a problem hiding this comment.
Let's double check if there is a way to allow dynamic types so that any bytesX works e.g. bytes420.
| ]; | ||
|
|
||
| // Keywords | ||
| export const keywords: CompletionItemData[] = [ |
Member
There was a problem hiding this comment.
Add loops to this once they're out
| // Check for bytes methods (identifier followed by dot) | ||
| // This is a heuristic - we show bytes methods after any identifier followed by a dot | ||
| // that doesn't match the above patterns | ||
| if (/\b\w+\s*\.\s*\w*$/.test(lineUntilPosition)) { |
Member
There was a problem hiding this comment.
Would be nice if there is some way that we can be sure that these only show on the correct type.
| ]; | ||
|
|
||
| // this.* properties | ||
| export const thisProperties: CompletionItemData[] = [ |
| // Extract local variable declarations | ||
| // Pattern: type varName = expression; | ||
| // CashScript types: int, bool, string, bytes, bytes1-32, pubkey, sig, datasig | ||
| const typePattern = '(?:int|bool|string|bytes(?:[1-9]|[12][0-9]|3[0-2])?|pubkey|sig|datasig)'; |
Member
There was a problem hiding this comment.
The bytesX regex looks very strange, this should just allow bytesX where X is any number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8