Skip to content

Fixing SQL issues when there are no service checks to perform #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheWitness merged 3 commits into from
Feb 4, 2026
Merged

Fixing SQL issues when there are no service checks to perform #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c49b92d
Small issue with no tests
TheWitness Feb 4, 2026
5319c95
Syntax error in SQL
TheWitness Feb 4, 2026
6df9de0
Update poller_servcheck.php
TheWitness Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions poller_servcheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@

$params = [];
$params[] = $poller_id;
$sql_where = 'AND poller_id = ?';
$sql_where = ' AND poller_id = ?';

if ($test_id > 0) {
$sql_where = ' AND id = ?';
Expand All @@ -173,8 +173,8 @@

$tests = db_fetch_assoc_prepared("SELECT *
FROM plugin_servcheck_test
WHERE enabled = 'on',
$sql_where",
WHERE enabled = 'on'
$sql_where",
$params);

$max_processes = read_config_option('servcheck_processes');
Expand Down Expand Up @@ -248,23 +248,25 @@
$stat_search_ok = 0;
$stat_search_ko = 0;

foreach ($tests as $test) {
$test_last = db_fetch_row_prepared('SELECT result, result_search
FROM plugin_servcheck_log
WHERE test_id = ?
ORDER BY id DESC LIMIT 1',
[$test['id']]);

if (isset($test_last['result']) && ($test_last['result'] == 'ok' || $test_last['result'] == 'not yet')) {
$stat_ok++;
} else {
$stat_ko++;
}
if (cacti_sizeof($tests)) {
foreach ($tests as $test) {
$test_last = db_fetch_row_prepared('SELECT result, result_search
FROM plugin_servcheck_log
WHERE test_id = ?
ORDER BY id DESC LIMIT 1',
[$test['id']]);

if (isset($test_last['result']) && ($test_last['result'] == 'ok' || $test_last['result'] == 'not yet')) {
$stat_ok++;
} else {
$stat_ko++;
}

if (isset($test_last['result_search']) && ($test_last['result_search'] == 'ok' || $test_last['result_search'] == 'not yet ' || $test_last['result_search'] == 'not tested')) {
$stat_search_ok++;
} else {
$stat_search_ko++;
if (isset($test_last['result_search']) && ($test_last['result_search'] == 'ok' || $test_last['result_search'] == 'not yet' || $test_last['result_search'] == 'not tested')) {
$stat_search_ok++;
} else {
$stat_search_ko++;
}
}
}

Expand Down