Only output transactionShippingMethod for non-virtual Orders#29
Open
wpalmer wants to merge 1 commit intoCVM:masterfrom
Open
Only output transactionShippingMethod for non-virtual Orders#29wpalmer wants to merge 1 commit intoCVM:masterfrom
wpalmer wants to merge 1 commit intoCVM:masterfrom
Conversation
transactionShippingMethod was unconditionally attempting to output the shipping "Carrier Code". This is fine in most cases, but for "virtual" orders, no CarrierCode is defined, resulting in an illegal offset error (internal to Magento) when the non-existent carrier information is requested. To avoid this, add a ->getIsVirtual() check on the $order, and only request Shipping Carrier information for non-Virtual orders. This is the same logic (though not exactly the same method) used within core Magento code within the Checkout process, and so appears to be an expected condition for accessing such data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transactionShippingMethod was unconditionally attempting to output the
shipping "Carrier Code". This is fine in most cases, but for "virtual"
orders, no CarrierCode is defined, resulting in an illegal offset error
(internal to Magento) when the non-existent carrier information is
requested.
To avoid this, add a ->getIsVirtual() check on the $order, and only
request Shipping Carrier information for non-Virtual orders. This is the
same logic (though not exactly the same method) used within core Magento
code within the Checkout process, and so appears to be an expected
condition for accessing such data.