ci: add dual build artifacts to compare C vs Rust code paths#2207
Merged
ci: add dual build artifacts to compare C vs Rust code paths#2207
Conversation
Add -min-rust flag to linux/build that passes -DDISABLE_RUST to gcc, causing switchable modules (DTVCC, demuxer, AVC, networking, hex utils) to use their C implementations instead of Rust. The Rust library still compiles since many modules are Rust-only. The Linux CI now produces two artifacts: - "CCExtractor Linux build" — min Rust (C paths where available) - "CCExtractor Linux build (with migrations)" — max Rust Both should produce identical output on the sample platform. If they diverge, it means a Rust port introduced a behavioral difference. The sample platform will need a corresponding update to recognize and test the new "with migrations" artifact. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 578abca...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 578abca...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-min-rustflag tolinux/buildthat passes-DDISABLE_RUSTto gcc, using C implementations for switchable modules (DTVCC, demuxer, AVC, networking, hex utils) while still linking the Rust library for Rust-only modulesCCExtractor Linux build— min Rust (C paths where available)CCExtractor Linux build (with migrations)— max Rust (all Rust ports active)Notes
CCExtractor Linux build (with migrations)Test plan
-min-rustbuilds clean (no warnings)🤖 Generated with Claude Code