Skip to content

Fix null pointer dereference in Matroska parser on file open failure #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Mar 14, 2026
Merged

Fix null pointer dereference in Matroska parser on file open failure #2171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib_ccx/matroska.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2035,6 +2035,12 @@ int matroska_loop(struct lib_ccx_ctx *ctx)
mkv_ctx->current_second = 0;
mkv_ctx->filename = ctx->inputfile[ctx->current_file];
mkv_ctx->file = create_file(ctx);
if (mkv_ctx->file == NULL)
{
char *fname = mkv_ctx->filename;
free(mkv_ctx);
fatal(EXIT_READ_ERROR, "Could not open MKV file: %s\n", fname);
}
mkv_ctx->sub_tracks = malloc(sizeof(struct matroska_sub_track **));
if (mkv_ctx->sub_tracks == NULL)
fatal(EXIT_NOT_ENOUGH_MEMORY, "In matroska_loop: Out of memory allocating sub_tracks.");
Expand Down
Loading