-
Notifications
You must be signed in to change notification settings - Fork 2
feat(algorithms, hash table): first unique character in string #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis pull request introduces a new algorithm for the "First Unique Character" problem in the hash table category. It includes problem documentation, a working implementation using character frequency counting, comprehensive test coverage with parameterized test cases, and updates to the directory index. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@algorithms/hash_table/first_unique_character/README.md`:
- Around line 1-35: Add a reference URL for the problem statement to the README
for "First Unique Character": update the top description block (the section
starting with the title "First Unique Character" and the one-line problem
statement) to include a source link (for example LeetCode problem URL) labeled
clearly as "Reference" or "Source" immediately after the description paragraph
so readers can follow to the original problem; ensure the link is a full URL and
use the same README header area where the problem is described.
In `@DIRECTORY.md`:
- Around line 169-170: The unordered list items for "First Unique Character" are
mis-indented causing markdownlint MD007; fix by aligning the two list lines to
the same nesting level as the surrounding "Hash Table" block—ensure the bullet
for "First Unique Character" and its nested link line use consistent spaces
(match the other top-level list item indentation in the Hash Table section) so
both the item label "First Unique Character" and the link "[Test First Unique
Character](https://github.com/BrianLusina/PythonSnips/blob/master/algorithms/hash_table/first_unique_character/test_first_unique_character.py)"
share the same indentation depth and the UL nesting is consistent.
Describe your change:
First unique character in string
Checklist:
Fixes: #{$ISSUE_NO}.Summary by CodeRabbit
Release Notes
New Features
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.